From: Amit Choudhary <amitchoudhary2305@gmail.com>
To: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
Cc: kstewart@linuxfoundation.org, linux-kernel@vger.kernel.org,
rfontana@redhat.com, tglx@linutronix.de, mchehab@kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-media@vger.kernel.org
Subject: Re: [Linux-kernel-mentees] [PATCH 4/6] media: dvb_dummy_fe: Fix long lines
Date: Sun, 1 Dec 2019 22:07:22 +0530 [thread overview]
Message-ID: <CAFzckaFfmVYV_baqV9bHrnguXfOKs42DJ2VgA4C1y2Ey-+99xQ@mail.gmail.com> (raw)
In-Reply-To: <20191201161542.69535-5-dwlsalmeida@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 637 bytes --]
+static int dvb_dummy_fe_read_signal_strength(struct dvb_frontend *fe,
> + u16 *strength)
>
In my opinion, the arguments on new line should be just below the start of
arguments on top line. Like this:
+static int dvb_dummy_fe_read_signal_strength(struct dvb_frontend *fe,
+ u16
*strength)
+ .caps = FE_CAN_FEC_1_2 |
> + FE_CAN_FEC_2_3 |
>
Similarly, here too and other places too:
+ .caps = FE_CAN_FEC_1_2 |
+ FE_CAN_FEC_2_3 |
Regards,
Amit
[-- Attachment #1.2: Type: text/html, Size: 1306 bytes --]
[-- Attachment #2: Type: text/plain, Size: 201 bytes --]
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2019-12-01 16:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-01 16:15 [Linux-kernel-mentees] [PATCH 0/6] dummy_dvb_fe: Tidy up the dummy frontend Daniel W. S. Almeida
2019-12-01 16:15 ` [Linux-kernel-mentees] [PATCH 1/6] media: dvb_dummy_fe: place EXPORT_SYMBOL below corresponding function Daniel W. S. Almeida
2019-12-01 16:15 ` [Linux-kernel-mentees] [PATCH 2/6] media: dvb_dummy_fe: Add error messages in case of attach failure Daniel W. S. Almeida
2019-12-31 10:20 ` Sean Young
2019-12-01 16:15 ` [Linux-kernel-mentees] [PATCH 3/6] media: dvb_dummy_fe: Fix ERROR: POINTER_LOCATION Daniel W. S. Almeida
2019-12-31 10:08 ` Sean Young
2019-12-31 18:14 ` Daniel W. S. Almeida
2019-12-31 18:34 ` Sean Young
2019-12-01 16:15 ` [Linux-kernel-mentees] [PATCH 4/6] media: dvb_dummy_fe: Fix long lines Daniel W. S. Almeida
2019-12-01 16:37 ` Amit Choudhary [this message]
2019-12-02 5:35 ` Mauro Carvalho Chehab
2019-12-01 16:15 ` [Linux-kernel-mentees] [PATCH 5/6] media: dvb_dummy_fe: Add blank line after declaration Daniel W. S. Almeida
2019-12-01 16:15 ` [Linux-kernel-mentees] [PATCH 6/6] media: dvb_dummy_frontend: remove 'extern' keyword from declaration Daniel W. S. Almeida
2019-12-31 10:12 ` Sean Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFzckaFfmVYV_baqV9bHrnguXfOKs42DJ2VgA4C1y2Ey-+99xQ@mail.gmail.com \
--to=amitchoudhary2305@gmail.com \
--cc=dwlsalmeida@gmail.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rfontana@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).