From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Mrinal Pandey <mrinalmni@gmail.com>
Cc: Linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH] checkpatch: Adjust spelling check false positive
Date: Fri, 10 Jul 2020 23:47:01 +0200 [thread overview]
Message-ID: <CAKXUXMx8RcQrihaYvryhm4N8X4BATLpPmRnDkm6nCmhznugd0g@mail.gmail.com> (raw)
In-Reply-To: <CAD1=X6mM0cA-8aVO4YaLiUbSnkw0EKCijL12bDWxNfUCaCh87g@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1027 bytes --]
>> For Issue 5: Can you provide me (and the CC: the list) the list of
>> false positives (the commit hashes) you found for issue 5 on
>> EXPORT_SYMBOL?
>
>
> Here are the commit hashes for which the warning is issued:
> 54505a1e2083
> 75d75b7a4d54
> 8084c99b9af6
> bfdaf029c9c9
> dfd402a4c4ba
>
>> Can you also provide a short rationale/explanation for
>> each case that you considered a false positive?
>
>
> In each case the `EXPORT_SYMBOL()` is correctly written and the
variable/function to be exported
> is also inside the parentheses, still, we get the warning. Please let me
know if I am wrong here.
I checked those warnings. Some of the patches are good cases to check if we
can improve the heuristics on EXPORT_SYMBOL().
E.g., commit bfdaf029c9c9 ("ia64: turn csum_partial_copy_from_user() into
csum_and_copy_from_user()") looks sound to me, and checkpatch.pl should not
really warn about that.
Mrinal, maybe you can find out why checkpatch.pl believes that this case is
wrong and needs to be warned about?
Lukas
[-- Attachment #1.2: Type: text/html, Size: 1386 bytes --]
[-- Attachment #2: Type: text/plain, Size: 201 bytes --]
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-07-10 21:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 8:08 [Linux-kernel-mentees] [PATCH] checkpatch: Adjust spelling check false positive Mrinal Pandey
2020-07-06 19:50 ` Lukas Bulwahn
[not found] ` <CAD1=X6m06KWb3=VEGkFWpmmV=UC09ZYbj2qpAOyg6OPFM=8KqA@mail.gmail.com>
[not found] ` <CAKXUXMy_KAHn+FNWviazVcEqK213uLVksq8_8HhjXAW+_OBrzQ@mail.gmail.com>
[not found] ` <CAD1=X6==MgT6jaNZ9PsPUqV1QTRFKguq9zvV+TtFSHyajFMjUg@mail.gmail.com>
2020-07-09 5:03 ` Lukas Bulwahn
2020-07-10 11:26 ` Mrinal Pandey
2020-07-10 20:46 ` Shuah Khan
2020-07-10 21:15 ` Lukas Bulwahn
2020-07-11 13:40 ` Mrinal Pandey
2020-07-10 21:31 ` Lukas Bulwahn
2020-07-11 13:37 ` Mrinal Pandey
2020-07-10 21:47 ` Lukas Bulwahn [this message]
2020-07-14 14:56 ` Mrinal Pandey
2020-07-15 5:32 ` Lukas Bulwahn
2020-07-18 7:00 ` Mrinal Pandey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKXUXMx8RcQrihaYvryhm4N8X4BATLpPmRnDkm6nCmhznugd0g@mail.gmail.com \
--to=lukas.bulwahn@gmail.com \
--cc=Linux-kernel-mentees@lists.linuxfoundation.org \
--cc=mrinalmni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).