The usage of "capture group (...)" in the immediate condition after `&&`
results in `$1` being uninitialized. This eventually crashes the script.
It does not really crash it, right? It just emits a warning.
Sir,
Yes. I will modify the line accordingly.
Fix this by placing the capture group in the condition before `&&`.
Thus, `$1` can be initialized to the text it matches thereby setting it
to the desired and required value.
Maybe you can look when this bug was introduced?
The bug was first introduced with the commit `e518e9a59ec3` when the block was
added to the script. It has been like that since then.
Should I add this detail too in the commit message?
Yes, please do.
Commits are referred to with its hash shortened to 12 characters and the commit message header in the following format:
Commit e518e9a59ec3 ("checkpatch: emit an error when there's a diff in a changelog")
Further note:
- can you also explain what the author intended to do?
- can you describe in one sentence how you discovered this bug?
Please rework the commit message and resend to this list, Shuah and me.
I think if that patch is then okay, we have a quick look and then you can send it out to the general list.
Lukas