From: David Lechner <dlechner@baylibre.com>
To: Anshul Dalal <anshulusr@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
Jonathan Cameron <jic23@kernel.org>,
devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
Shuah Khan <skhan@linuxfoundation.org>,
Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: dac: add MCP4821
Date: Sun, 17 Dec 2023 19:29:40 -0600 [thread overview]
Message-ID: <CAMknhBHoK-ZB1MpJmM3jbbBpyCbRYcRWPG02fxJ5OY6PLB7ZEg@mail.gmail.com> (raw)
In-Reply-To: <CAMknhBGR7WS46J+MeqY51RhMb78AoUO6URaFxw2M83P29fqzdQ@mail.gmail.com>
On Sun, Dec 17, 2023 at 7:25 PM David Lechner <dlechner@baylibre.com> wrote:
>
> On Sun, Dec 17, 2023 at 12:11 PM Anshul Dalal <anshulusr@gmail.com> wrote:
> >
> > Adds support for MCP48xx series of DACs.
> >
> > Datasheet: https://ww1.microchip.com/downloads/en/DeviceDoc/22244B.pdf #MCP48x1
> > Datasheet: https://ww1.microchip.com/downloads/en/DeviceDoc/20002249B.pdf #MCP48x2
> > Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> > Signed-off-by: Anshul Dalal <anshulusr@gmail.com>
> >
> > ---
> >
> > Changes for v2:
> > - Changed order in device table to numerical
> > - Made vdd_supply required
> > - Added 'Reviewed-by: Conor Dooley'
> >
> > Previous versions:
> > v1: https://lore.kernel.org/lkml/20231117073040.685860-1-anshulusr@gmail.com/
> > ---
> > .../bindings/iio/dac/microchip,mcp4821.yaml | 64 +++++++++++++++++++
> > 1 file changed, 64 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/iio/dac/microchip,mcp4821.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/iio/dac/microchip,mcp4821.yaml b/Documentation/devicetree/bindings/iio/dac/microchip,mcp4821.yaml
> > new file mode 100644
> > index 000000000000..97da9f9ef450
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/dac/microchip,mcp4821.yaml
> > @@ -0,0 +1,64 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/dac/microchip,mcp4821.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Microchip MCP4821 and similar DACs
> > +
> > +description: |
> > + Supports MCP48x1 (single channel) and MCP48x2 (dual channel) series of DACs.
> > + Device supports simplex communication over SPI in Mode 0,1 and Mode 1,1.
>
> It seems like SPI modes usually only have one number in them, i.e.
> mode 1 and mode 3 in this case, I'm guessing.
Oh, and doesn't this mean that we need to include spi-cpha and
spi-cpol properties since they aren't implicit in the bindings anymore
since [1]?
[1]: https://lore.kernel.org/all/20220722191539.90641-2-krzysztof.kozlowski@linaro.org/
>
> > +
> > + +---------+--------------+-------------+
> > + | Device | Resolution | Channels |
> > + |---------|--------------|-------------|
> > + | MCP4801 | 8-bit | 1 |
> > + | MCP4802 | 8-bit | 2 |
> > + | MCP4811 | 10-bit | 1 |
> > + | MCP4812 | 10-bit | 2 |
> > + | MCP4821 | 12-bit | 1 |
> > + | MCP4822 | 12-bit | 2 |
> > + +---------+--------------+-------------+
> > +
> > + Datasheet:
> > + MCP48x1: https://ww1.microchip.com/downloads/en/DeviceDoc/22244B.pdf
> > + MCP48x2: https://ww1.microchip.com/downloads/en/DeviceDoc/20002249B.pdf
> > +
> > +maintainers:
> > + - Anshul Dalal <anshulusr@gmail.com>
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - microchip,mcp4801
> > + - microchip,mcp4802
> > + - microchip,mcp4811
> > + - microchip,mcp4812
> > + - microchip,mcp4821
> > + - microchip,mcp4822
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + vdd-supply: true
>
> What about the SHDN and LDAC pins? It seems like all should have an
> ldac-gpios property and MCP48x1 should have a shdn-gpios property for
> these.
>
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - vdd-supply
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + spi {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + dac@0 {
> > + compatible = "microchip,mcp4821";
> > + reg = <0>;
> > + vdd-supply = <&vdd_regulator>;
> > + };
> > + };
> > --
> > 2.43.0
> >
> >
prev parent reply other threads:[~2023-12-18 1:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-17 18:08 [PATCH v2 1/2] dt-bindings: iio: dac: add MCP4821 Anshul Dalal
2023-12-17 18:08 ` [PATCH v2 2/2] iio: dac: driver for MCP4821 Anshul Dalal
2023-12-20 14:23 ` Jonathan Cameron
2023-12-18 1:25 ` [PATCH v2 1/2] dt-bindings: iio: dac: add MCP4821 David Lechner
2023-12-18 1:29 ` David Lechner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMknhBHoK-ZB1MpJmM3jbbBpyCbRYcRWPG02fxJ5OY6PLB7ZEg@mail.gmail.com \
--to=dlechner@baylibre.com \
--cc=anshulusr@gmail.com \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).