From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Ujjwal Kumar <ujjwalkumar0501@gmail.com>
Subject: Re: [Linux-kernel-mentees] [RFC PATCH v2] checkpatch: add shebang check to EXECUTE_PERMISSIONS
Date: Wed, 14 Oct 2020 19:45:59 +0200 [thread overview]
Message-ID: <CANiq72kogiVbBURCrb74_vCPCLb09LGTudxE-QG8US7pX8LqQw@mail.gmail.com> (raw)
In-Reply-To: <316d5a53351d10cd1a26ce0c54883da05642c898.camel@perches.com>
On Wed, Oct 14, 2020 at 10:40 AM Joe Perches <joe@perches.com> wrote:
>
> Eek no.
>
> Mindless use of either tool isn't a great thing.
That is up to opinion. I (and others) definitely want to get to the
point the kernel sources are automatically formatted, because it has
significant advantages. The biggest is that it saves a lot of time for
everyone involved.
> Linux source code has generally be created with
> human readability in mind by humans, not scripts.
Code readability is by definition for humans, and any code formatter
(like clang-format) is written for them.
> Please don't try to replace human readable code
> with mindless tools.
Please do :-)
> There is a _lot_ of relatively inappropriate
> output in how clang-format changes existing code
> in the kernel.
Sure, but note that:
- Code that should be specially-formatted should be in a
clang-format-off section to begin with, so it doesn't count.
- Some people like to tweak identifiers or refactor code to make it
fit in the line limit beautifully. If you are doing that, then you
should do that for clang-format too. It is not fair to compare both
outputs when the tool is restricted on the transformations it can
perform. You can help the tool, too, the same way you can help
yourself.
- Some style differences may be worth ignoring if the advantage is
getting automatic formatting.
Cheers,
Miguel
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-10-14 17:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 12:01 [Linux-kernel-mentees] [RFC PATCH v2] checkpatch: add shebang check to EXECUTE_PERMISSIONS Ujjwal Kumar
2020-10-13 12:13 ` Ujjwal Kumar
2020-10-13 15:27 ` Joe Perches
2020-10-14 5:46 ` Lukas Bulwahn
2020-10-14 6:01 ` Joe Perches
2020-10-14 6:21 ` Lukas Bulwahn
2020-10-14 6:27 ` Joe Perches
2020-10-14 6:36 ` Lukas Bulwahn
2020-10-14 6:39 ` Joe Perches
2020-10-14 6:47 ` Lukas Bulwahn
2020-10-14 6:58 ` Joe Perches
2020-10-14 7:17 ` Lukas Bulwahn
2020-10-14 7:35 ` Joe Perches
2020-10-14 17:45 ` Miguel Ojeda [this message]
2020-10-14 18:05 ` Joe Perches
2020-10-14 18:32 ` Miguel Ojeda
2020-10-14 18:37 ` Joe Perches
2020-10-14 11:14 ` Ujjwal Kumar
2020-10-16 9:05 ` Ujjwal Kumar
2020-10-16 10:10 ` Lukas Bulwahn
2020-10-16 10:24 ` Dwaipayan Ray
2020-10-16 10:33 ` Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANiq72kogiVbBURCrb74_vCPCLb09LGTudxE-QG8US7pX8LqQw@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ujjwalkumar0501@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).