From: Jiri Pirko <jiri@resnulli.us>
To: swarup <swarupkotikalapudi@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH net-next v5] netlink: specs: devlink: add some(not all) missing attributes in devlink.yaml
Date: Sun, 10 Dec 2023 12:47:25 +0100 [thread overview]
Message-ID: <ZXWlTYyPF0nj1wof@nanopsycho> (raw)
In-Reply-To: <ZXNgrTDRd+nFa1Ad@swarup-virtual-machine>
Fri, Dec 08, 2023 at 07:30:05PM CET, swarupkotikalapudi@gmail.com wrote:
>On Wed, Dec 06, 2023 at 08:06:11AM -0800, Jakub Kicinski wrote:
>> On Wed, 6 Dec 2023 08:51:54 +0100 Jiri Pirko wrote:
>> > My "suggested-by" is probably fine as I suggested Swarup to make the patch :)
>>
>> Ah, I didn't realize, sorry :) Just mine needs to go then.
>
>Hi Jiri,
>
>Please find answer for some quesion from you.
>
>1. I removed the Fixes tag.
>
>2. I removed Jakub's name from Suggested-by tag.
>
>3. I added new line as suggested.
>
> value: ## or number, is used only if there is a gap or
> missing attribute just above of any attribute which is not yet filled.
>
>4. dl-attr-stats has a value 0 as shown below for this reason:
> name: dl-attr-stats
> name-prefix: devlink-attr-
> attributes:
> - name: stats-rx-packets
> type: u64
> value: 0 <-- 0 is added here due to below mentioned reason
> but mainly to match order of stats unnamed enum declared in include/uapi/linux/devlink.h
So, by default, it starts with 1?
> -
> name: stats-rx-bytes
> type: u64
> -
> name: stats-rx-dropped
> type: u64
next prev parent reply other threads:[~2023-12-10 11:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-02 12:30 [PATCH net-next v5] netlink: specs: devlink: add some(not all) missing attributes in devlink.yaml Swarup Laxman Kotiaklapudi
2023-12-06 3:19 ` Jakub Kicinski
2023-12-06 7:51 ` Jiri Pirko
2023-12-06 16:06 ` Jakub Kicinski
2023-12-07 2:08 ` swarup
2023-12-08 18:30 ` swarup
2023-12-10 11:47 ` Jiri Pirko [this message]
2023-12-10 17:44 ` swarup
2023-12-06 13:18 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXWlTYyPF0nj1wof@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=swarupkotikalapudi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).