From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 352682F876 for ; Sat, 25 Nov 2023 19:36:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OQrkcuYq" Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 943F74016C for ; Sat, 25 Nov 2023 19:36:55 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 943F74016C Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=OQrkcuYq X-Virus-Scanned: amavisd-new at osuosl.org X-Spam-Flag: NO X-Spam-Score: -1.849 X-Spam-Level: Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nw21dmRP39qu for ; Sat, 25 Nov 2023 19:36:54 +0000 (UTC) Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by smtp2.osuosl.org (Postfix) with ESMTPS id A1E85400EF for ; Sat, 25 Nov 2023 19:36:54 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org A1E85400EF Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-6cb90b33c1dso749429b3a.0 for ; Sat, 25 Nov 2023 11:36:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700941014; x=1701545814; darn=lists.linuxfoundation.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7mSy6AtK6hcZt+Drsghr+39VrktzL88A/9JIeiEL+z4=; b=OQrkcuYq7IMzosIitTKc4m0oM05Wnx1MoM1L02ppq0U8F+MkBvKkx2Qw2cj84G65Iz ZTDuDH8JyfeBe9E4/eKgv5EW3Vmy9H4fRjoINl3jwpvEx3Y7fvfsjCgmdupY4rZlj5U9 9mJKFHgWYPdI3qPMxBB4W/wdBPEhxiOnSnw9VwiHSHYKxPxYAK9BWVEWu53B6DDDSfW2 7su+G8xN/Nma4D4vPZcpnhMQoMj9aB1rfM52K7IOwSAjjMvSwW5vR16Iql9Fd4mkJM2U OuDM6I34s9E+r3BUkEdxAHL6ALA28wqx5JmKCqMilatLUyMaO0e3Ln/QcsWK52EjKOVh m34Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700941014; x=1701545814; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7mSy6AtK6hcZt+Drsghr+39VrktzL88A/9JIeiEL+z4=; b=BQl3uezUchXepUOequCSimoyGIhcQqUOfLTH0Xl9VzyJhTPoHcHB7M8MX2/kz8y3AL lW/+A9ObEphZ7K3psEYXwDmjjaWJQmYvMpex+rFmWd6CsshO1bUn/j6l1rdnevHhUxV4 lDvYbujRXGk4B3PqrHP38VAwH73yseRIjTW7qywGsbCRUML0Dgz55t9MZyTvKrRXd1gw YmXB2UkvC67Ivnzsn8BtJC4LbWG2c67MdW11hKFYfSkdc31oOtQNaPpGLgGN29xuT9Og t09HNLQ+HPSOZZgDBTPqW1rLD1OtdHR8O1xD7XfeYIhL1zDLVQBWp6gQSbnNoaFeY6BV WPsg== X-Gm-Message-State: AOJu0YzpCSWCJfVOYSEfgCQYFInrB9LBk8ABBlq2+ptop5zF4yXCvZjo xrILwpWNldfYfaRXs5dRnAw= X-Google-Smtp-Source: AGHT+IFIYPXLZu1LFRAkgi5+zqXfm64WTV8o7ktHpacr0iImqsrY5DIuF+3qzI3NBYATNESj4FLsUw== X-Received: by 2002:a05:6a20:7f8c:b0:18b:8158:dfa4 with SMTP id d12-20020a056a207f8c00b0018b8158dfa4mr9909038pzj.5.1700941013947; Sat, 25 Nov 2023 11:36:53 -0800 (PST) Received: from [192.168.0.152] ([103.75.161.210]) by smtp.gmail.com with ESMTPSA id x23-20020aa793b7000000b006cb638ba1aasm4610588pff.49.2023.11.25.11.36.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Nov 2023 11:36:53 -0800 (PST) Message-ID: Date: Sun, 26 Nov 2023 01:06:48 +0530 Precedence: bulk X-Mailing-List: linux-kernel-mentees@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] driver: scsi: Fix warning using plain integer as NULL Content-Language: en-US To: oliver@neukum.org, aliakc@web.de, lenehan@twibble.org, jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org References: <20231109215049.1466431-1-singhabhinav9051571833@gmail.com> From: Abhinav Singh In-Reply-To: <20231109215049.1466431-1-singhabhinav9051571833@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/10/23 03:20, Abhinav Singh wrote: > Sparse static analysis tools generate a warning with this message > "Using plain integer as NULL pointer". In this case this warning is > being shown because we are trying to initialize pointer to NULL using > integer value 0. > > Signed-off-by: Abhinav Singh > --- > drivers/scsi/dc395x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c > index c8e86f8a631e..d108a86e196e 100644 > --- a/drivers/scsi/dc395x.c > +++ b/drivers/scsi/dc395x.c > @@ -1366,7 +1366,7 @@ static u8 start_scsi(struct AdapterCtlBlk* acb, struct DeviceCtlBlk* dcb, > "command while another command (0x%p) is active.", > srb->cmd, > acb->active_dcb->active_srb ? > - acb->active_dcb->active_srb->cmd : 0); > + acb->active_dcb->active_srb->cmd : NULL); > return 1; > } > if (DC395x_read16(acb, TRM_S1040_SCSI_STATUS) & SCSIINTERRUPT) { Hello maintainers, any reviews or comments on this. Thank You, Abhinav Singh