Re: [Linux-kernel-mentees] [PATCH] checkpatch: GIT_COMMIT_ID: handle commit messages with multiple quotes

[Lukas Bulwahn <lukas.bulwahn@gmail.com>]

On Wed, 9 Sep 2020, Joe Perches wrote:

> On Wed, 2020-09-09 at 13:32 +0200, Lukas Bulwahn wrote:
> > dropped the maintainers.
> > 
> > On Wed, 9 Sep 2020, Ayush wrote:
> > 
> > > Sir,
> > > 
> > > > As the mentor in the linux kernel community bridge program, I usually
> > > > inform the mentees when the review on the mentee mailing list has
> > > > successfully concluded to a first acceptable state and I think it is well
> > > > advised to reach out to the maintainers for further discussion.
> > > > 
> > > > You did not do that, but just send some patch to the maintainers.
> > > > That is fully up to you, but I will not support the patch acceptance in
> > > > any way, and it suggests that you do not see the need to be mentored.
> > > > 
> > > > If you can land patches without mentoring support successfully, that is
> > > > great, but then you do not need a mentorship.
> > > 
> > > I am extremely sorry for my mistakes. It won't happen again.
> > >  
> > > > Now, to the commit:
> > > > 
> > > > Ayush, your commit message is largely incomprehensible.
> > > > 
> > > > Your follow-up explanation that was needed should have been in the commit
> > > > message in the first place.
> > > 
> > > It was my first patch, so I had very little idea of forming commit messages. 
> > > I will discuss it with mentors next time before sending the patch next time.
> > > 
> > 
> > Let us start with the simpler patch and then see if you can write a commit 
> > message that convinces Joe to ack your patch.
> >  
> > > > Ayush, you did not sign-off with your full legal name.
> > > 
> > > My legal name according to all official identification documents of India is Ayush. 
> > > I have no surname registered legally.
> > > So should I include "Ayush <ayush@disroot.org>"  or do I need to include my last name too (Which is Ayush only)?
> > > 
> > 
> > Okay. If you say so, I cannot judge but you should try to use a name that 
> > others can with a fair chance uniquely identify that is you.
> > 
> > The name is used in git log summaries, pull requests, etc.; so, it should 
> > be a name that with high chance to refer to one person.
> > 
> > Maybe you find a good way that works as suitable name for 
> > unique identification?
> 
> I believe the Developer's Certificate of Origin (DCO) in
> Documentation/pr
> ocess/submitting-patches.rst just asks
> for a "full name".
> 
> If Ayush has no surname, then I imagine that his actual
> full name Ayush should be good enough for the DCO.
> 
> A line like "Signed-off-by: Ayush <ayush@disroot.org>"
> should be fine.
>

Agree. Let us, Ayush and me, focus on getting some patches technically 
ready for your review, Joe, and with that, continue to improve 
checkpatch.pl.

Lukas
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees