From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Ayush <ayush@disroot.org>
Cc: linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH v2] checkpatch: handle line break between commit and hash value
Date: Sat, 12 Sep 2020 14:42:30 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2009121436470.3770@felia> (raw)
In-Reply-To: <20200912094826.150170-1-ayush@disroot.org>
On Sat, 12 Sep 2020, Ayush wrote:
> checkpatch.pl checks for proper references to other commits with
> the intended format, commit <12+ characters of SHA-1 ID> ("<commit
> message") and warns about typical mistakes. Currently, it does
> not handle the case where there is a line break between commit and the
> hash value.
> It falsely warns that the hash is not prefixed by the word commit.
>
> This adds new conditions to parse and identify such commits and
> to not report an error in such cases.
>
> following type of commit reference is handled:
>
> - commit
> f4d51dffc6c01 ("Linux 5.9-rc4")
>
> This issue was discovered through a thorough analysis of checkpatch.pl
> errors and warnings of type GIT_COMMIT_ID on commits between v5.7 and v5.8.
>
> Before applying this patch, checkpatch.pl reported 342 errors of type
> GIT_COMMIT_ID. After applying patch, errors reduced to 284.
>
> Signed-off-by: Ayush <ayush@disroot.org>
The patch does not apply on commit f4d51dffc6c0 ("Linux 5.9-rc4").
Applying: checkpatch: handle line break between commit and hash value
Checking patch scripts/checkpatch.pl...
error: while searching for:
my $git_command ='export LANGUAGE=en_US.UTF-8; git';
my $tabsize = 8;
my ${CONFIG_} = "CONFIG_";
sub help {
my ($exitcode) = @_;
error: patch failed: scripts/checkpatch.pl:68
Hunk #2 succeeded at 2825 (offset -6 lines).
Hunk #3 succeeded at 2841 (offset -6 lines).
Hunk #4 succeeded at 2872 (offset -6 lines).
Applying patch scripts/checkpatch.pl with 1 reject...
Rejected hunk #1.
Hunk #2 applied cleanly.
Hunk #3 applied cleanly.
Hunk #4 applied cleanly.
Patch failed at 0001 checkpatch: handle line break between commit and hash value
What commit is your patch based on?
Try always to test that the commit applies on the current master and on
the latest linux-next.
Lukas
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-09-12 12:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-12 9:48 [Linux-kernel-mentees] [PATCH v2] checkpatch: handle line break between commit and hash value Ayush
2020-09-12 11:17 ` Lukas Bulwahn
2020-09-12 12:42 ` Lukas Bulwahn [this message]
2020-09-12 13:34 ` Ayush
2020-09-12 14:15 ` Lukas Bulwahn
2020-09-12 15:38 ` Ayush
2020-09-12 19:37 ` Ayush
2020-09-13 11:01 ` Lukas Bulwahn
2020-09-13 12:06 ` Ayush
2020-09-13 18:09 ` Lukas Bulwahn
2020-09-13 20:53 ` Ayush
2020-09-14 5:12 ` Lukas Bulwahn
2020-09-17 14:53 ` Ayush
2020-09-17 15:17 ` Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2009121436470.3770@felia \
--to=lukas.bulwahn@gmail.com \
--cc=ayush@disroot.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).