From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] Linux kernel checkpatch.pl mentorship
Date: Sun, 13 Sep 2020 13:05:06 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2009131301570.22585@felia> (raw)
In-Reply-To: <CABJPP5BFNjBhdcvBWqDYnR-o2sZ0oY77bYr9PxducXW4Y=482Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1037 bytes --]
>
> As you told, I applied the patch and compared the statistics. In my case however the statistics
> vary. Before patching total no. of errors of type GIT_COMMIT_ID was 270, and after patching,
> the number went down to 251. This is in constrast to the author's finding but the number
> reduces, so the patch works apparently.
>
> I am posting the diff of statistics before and after the patch:
>
> 99c99
> < COMMIT_LOG_LONG_LINE: 1059
> ---
> > COMMIT_LOG_LONG_LINE: 1057
> 126c126
> < GIT_COMMIT_ID: 270
> ---
> > GIT_COMMIT_ID: 251
> 142,143c142,143
> < Warnings generated: 25661
> < Errors generated: 4768
> ---
> > Warnings generated: 25659
> > Errors generated: 4749
>
> As you can see, the warnings of type COMMIT_LOG_LONG_LINE decreased too.
>
Can you share the errors that have changed after the patch was applied?
- Which two cases of COMMIT_LOG_LONG_LINE have disappeared?
- Which cases of GIT_COMMIT_ID have disappeared?
- Which cases of GIT_COMMIT_ID are new?
- Which cases of GIT_COMMIT_ID have changed?
Lukas
[-- Attachment #2: Type: text/plain, Size: 201 bytes --]
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-09-13 11:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CABJPP5CSa_QowD-O3_E5ndoQJvuBv=n2x5WG-acwQKE=rt5+Rw@mail.gmail.com>
[not found] ` <alpine.DEB.2.21.2009110925160.9220@felia>
2020-09-12 9:09 ` [Linux-kernel-mentees] Linux kernel checkpatch.pl mentorship Dwaipayan Ray
2020-09-12 11:03 ` Lukas Bulwahn
2020-09-12 12:08 ` Dwaipayan Ray
2020-09-12 12:21 ` Lukas Bulwahn
2020-09-13 8:16 ` Dwaipayan Ray
2020-09-13 11:05 ` Lukas Bulwahn [this message]
[not found] ` <CABJPP5BmRcC+OTSjuX_QrYononVq__DkhjGOgiKrP147MAXK+g@mail.gmail.com>
[not found] ` <alpine.DEB.2.21.2009132015570.6806@felia>
2020-09-13 18:23 ` Dwaipayan Ray
[not found] ` <alpine.DEB.2.21.2009132010300.6806@felia>
2020-09-13 18:39 ` Dwaipayan Ray
2020-09-14 5:17 ` Lukas Bulwahn
2020-09-14 12:31 ` Dwaipayan Ray
2020-09-14 13:49 ` Lukas Bulwahn
2020-09-14 15:39 ` Dwaipayan Ray
2020-09-14 18:32 ` Lukas Bulwahn
2020-09-15 13:04 ` Dwaipayan Ray
2020-09-16 7:01 ` Lukas Bulwahn
2020-09-17 13:09 ` Dwaipayan Ray
2020-09-17 13:41 ` Dwaipayan Ray
2020-09-17 14:18 ` Lukas Bulwahn
2020-09-17 14:43 ` Dwaipayan Ray
2020-09-17 15:03 ` Lukas Bulwahn
2020-09-17 14:13 ` Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2009131301570.22585@felia \
--to=lukas.bulwahn@gmail.com \
--cc=dwaipayanray1@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).