From: Daniel Borkmann <daniel@iogearbox.net>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>,
"Amol Grover" <frextrite@gmail.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
"Jakub Kicinski" <jakub.kicinski@netronome.com>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"John Fastabend" <john.fastabend@gmail.com>,
"Martin KaFai Lau" <kafai@fb.com>,
"Song Liu" <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>,
"Andrii Nakryiko" <andriin@fb.com>
Cc: "Paul E . McKenney" <paulmck@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Joel Fernandes <joel@joelfernandes.org>,
bpf@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH] bpf: devmap: Pass lockdep expression to RCU lists
Date: Thu, 23 Jan 2020 16:59:09 +0100 [thread overview]
Message-ID: <b019ff62-08f5-1536-48f3-484b9dc2e064@iogearbox.net> (raw)
In-Reply-To: <87d0ba9ttp.fsf@toke.dk>
On 1/23/20 2:38 PM, Toke Høiland-Jørgensen wrote:
> Amol Grover <frextrite@gmail.com> writes:
>
>> head is traversed using hlist_for_each_entry_rcu outside an
>> RCU read-side critical section but under the protection
>> of dtab->index_lock.
>>
>> Hence, add corresponding lockdep expression to silence false-positive
>> lockdep warnings, and harden RCU lists.
>>
>> Signed-off-by: Amol Grover <frextrite@gmail.com>
>
> Could you please add an appropriate Fixes: tag?
+1, please reply with Fixes: tag (no need to resend).
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-01-23 15:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 12:04 [Linux-kernel-mentees] [PATCH] bpf: devmap: Pass lockdep expression to RCU lists Amol Grover
2020-01-23 13:37 ` Jesper Dangaard Brouer
2020-01-23 13:42 ` Toke Høiland-Jørgensen
2020-01-23 17:10 ` Amol Grover
2020-01-23 13:38 ` Toke Høiland-Jørgensen
2020-01-23 15:59 ` Daniel Borkmann [this message]
2020-01-23 17:18 ` Amol Grover
2020-01-23 22:04 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b019ff62-08f5-1536-48f3-484b9dc2e064@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=frextrite@gmail.com \
--cc=hawk@kernel.org \
--cc=jakub.kicinski@netronome.com \
--cc=joel@joelfernandes.org \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=songliubraving@fb.com \
--cc=toke@redhat.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).