From: Anshul Dalal <anshulusr@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v5 2/2] iio: dac: driver for MCP4821
Date: Thu, 21 Dec 2023 22:46:36 +0530 [thread overview]
Message-ID: <d547f3cb-c03d-4871-b4c4-26dbb0a61495@gmail.com> (raw)
In-Reply-To: <20231221170706.27f5b76f@jic23-huawei>
On 12/21/23 22:37, Jonathan Cameron wrote:
> On Wed, 20 Dec 2023 20:49:53 +0530
> Anshul Dalal <anshulusr@gmail.com> wrote:
>
>> Adds driver for the MCP48xx series of DACs.
>>
>> Device uses a simplex SPI channel. To set the value of an output channel,
>> a 16-bit data of following format must be written:
>>
>> Bit field | Description
>> 15 [MSB] | Channel selection bit
>> 0 -> Channel A
>> 1 -> Channel B
>> 13 | Output Gain Selection bit
>> 0 -> 2x Gain (Vref = 4.096V)
>> 1 -> 1x Gain (Vref = 2.048V)
>> 12 | Output Shutdown Control bit
>> 0 -> Shutdown the selected channel
>> 1 -> Active mode operation
>> 11-0 [LSB]| DAC Input Data bits
>> Value's big endian representation is taken as input for the
>> selected DAC channel. For devices with a resolution of less
>> than 12-bits, only the x most significant bits are considered
>> where x is the resolution of the device.
>> Reference: Page#22 [MCP48x2 Datasheet]
>>
>> Supported devices:
>> +---------+--------------+-------------+
>> | Device | Resolution | Channels |
>> |---------|--------------|-------------|
>> | MCP4801 | 8-bit | 1 |
>> | MCP4802 | 8-bit | 2 |
>> | MCP4811 | 10-bit | 1 |
>> | MCP4812 | 10-bit | 2 |
>> | MCP4821 | 12-bit | 1 |
>> | MCP4822 | 12-bit | 2 |
>> +---------+--------------+-------------+
>>
>> Devices tested:
>> MCP4821 [12-bit single channel]
>> MCP4802 [8-bit dual channel]
>>
>> Tested on Raspberry Pi Zero 2W
>>
>> Datasheet: https://ww1.microchip.com/downloads/en/DeviceDoc/22244B.pdf #MCP48x1
>> Datasheet: https://ww1.microchip.com/downloads/en/DeviceDoc/20002249B.pdf #MCP48x2
>> Signed-off-by: Anshul Dalal <anshulusr@gmail.com>
>
> I've applied this to my tree with a few formatting tweaks. However, timing is such
> that, unless 6.7 release is delayed, the merge window will open too soon for me
> to get another pull request in. A such this is now almost certainly queued up
> for the 6.9 cycle in a few months time. That's probably a good thing anyway as
> some people will already be on vacation and may want to take another look at this
> when then get back.
>
> Applied to the togreg branch of iio.git and pushed out as testing for 0-day
> to take a look at it.
>
Thanks for the code reviews and help in getting this and my other
drivers (ltr390 and ags02ma) ready for upstream. I wish to contribute
more in the upcoming year.
Best Wishes,
Anshul
prev parent reply other threads:[~2023-12-21 17:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 15:19 [PATCH v5 1/2] dt-bindings: iio: dac: add MCP4821 Anshul Dalal
2023-12-20 15:19 ` [PATCH v5 2/2] iio: dac: driver for MCP4821 Anshul Dalal
2023-12-21 17:07 ` Jonathan Cameron
2023-12-21 17:16 ` Anshul Dalal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d547f3cb-c03d-4871-b4c4-26dbb0a61495@gmail.com \
--to=anshulusr@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).