linux-kernel-mentees.lists.linuxfoundation.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [Linux-kernel-mentees] [PATCH v5] checkpatch: add new exception to repeated word check
Date: Sun, 18 Oct 2020 00:11:20 -0700	[thread overview]
Message-ID: <e417e506c23ad56b2618204071c86e8a6ec2cb85.camel@perches.com> (raw)
In-Reply-To: <CABJPP5Cr3giDJkJvBDd62iwx6y6r1dFhaVXp9jYXS8Y6k9b09A@mail.gmail.com>

On Sun, 2020-10-18 at 12:10 +0530, Dwaipayan Ray wrote:
> print index(" \t.,;?!", '');
> 
> It output 0 in my case. So last words on a line seems to work.
> I don't know if this changes with the perl version though.
> 
> So given this, will it be necessary to change end_char to ' ' ?
> or perhaps change both start_char and end_char to a ' ' to maintain
> uniformity?

It seems it's fine even back to perl 5.6, so it's fine as is.

cheers, Joe


_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

  reply	other threads:[~2020-10-18  7:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-17 16:27 [Linux-kernel-mentees] [PATCH v5] checkpatch: add new exception to repeated word check Dwaipayan Ray
2020-10-17 16:33 ` Joe Perches
2020-10-17 16:49   ` Dwaipayan Ray
2020-10-18  6:20     ` Joe Perches
2020-10-18  6:40       ` Dwaipayan Ray
2020-10-18  7:11         ` Joe Perches [this message]
2020-10-18 16:50           ` Dwaipayan Ray
2020-10-18 18:04 ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e417e506c23ad56b2618204071c86e8a6ec2cb85.camel@perches.com \
    --to=joe@perches.com \
    --cc=dwaipayanray1@gmail.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).