From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A9A8D278 for ; Sat, 23 Dec 2023 10:25:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="g7PGdNOR" Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id B3A894214A for ; Sat, 23 Dec 2023 10:25:57 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org B3A894214A Authentication-Results: smtp4.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=g7PGdNOR X-Virus-Scanned: amavisd-new at osuosl.org X-Spam-Flag: NO X-Spam-Score: -2.099 X-Spam-Level: Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id E_pODpA5F-iB for ; Sat, 23 Dec 2023 10:25:55 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id 90C5E421D1 for ; Sat, 23 Dec 2023 10:25:54 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 90C5E421D1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703327151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GoKXir54x/dEEkfvtrxnT2ENR9sxqwMkgds0ZkJeGss=; b=g7PGdNOROm/CI8Qa7VoGGTRnFZPoBByiUBFxRU9HXivBPRrAy+W3KiEyPPnK6OCO8lUiKD sRNXOBGOEa32z9/gk5tNEpD4WnIuJ5mNDHaWnoH0UdY/XuZCBiXYVG+0IxC/88LXZYLwjq 7H0e/IEDodMCsTpkceYiyre3Bpv6eUA= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-290-itP1sixHOauzDfV2wXSiJA-1; Sat, 23 Dec 2023 05:25:48 -0500 X-MC-Unique: itP1sixHOauzDfV2wXSiJA-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a26d99fe6d7so10385866b.0 for ; Sat, 23 Dec 2023 02:25:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703327147; x=1703931947; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GoKXir54x/dEEkfvtrxnT2ENR9sxqwMkgds0ZkJeGss=; b=kZbGCFE0+bKc06h3iMJNSQFv3FjR6XdVaa6UKK2/yxC8gllxk+xyrNHyRWPI+AVYZL Qh4TrJ/V1jRMNEE1W9Q18oZkZx3VxsWiFtjLhgzZQEfLeqDgG6XOwKOyJ35H3z6bCoeJ 1/ULUs/avaXxnY/gJ/wXgiRNWAORQUWrR7yUJ1ZOGp2Ete+M+iTQxI92fbQ/lZXmENUh 1GEN1w/Yz31UfOSMA86knUIIAfMfAdc9+WpLZCC4GZHOMfHaNRQQVckVpGyDmd3AoiE2 kECLTQLp9MR2ZpHyKyWBnkOFzzRIj/VzHDD0YZYNtlaKrybHP8nFsdwhlNbc2+y8B0vA FZ0w== X-Gm-Message-State: AOJu0YxIxzoWAriuoejbNLvLM0bMRwkixS062NkaqDgM6XGy12TzJf06 in1YbzbXV/ON4iTdrATBq1Lm2H0PVV26wOwZA27e6eldnKFbbtjqI6+9M2KrRNki20U2uw3Uv/Q lrVvRItWOUCUlzJOgdu8ezVjyMuZmrKcYME7czN3zRukSbc9ARXgJQYNF X-Received: by 2002:a17:906:48:b0:a26:9734:d074 with SMTP id 8-20020a170906004800b00a269734d074mr1256577ejg.21.1703327147451; Sat, 23 Dec 2023 02:25:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IFfYBntxU/LEH18ZD4tGgJi1jr2AFoUSUHqm44HH3HbItCx3zDGERqgnKjQD0P1rx5/Ye1TzA== X-Received: by 2002:a17:906:48:b0:a26:9734:d074 with SMTP id 8-20020a170906004800b00a269734d074mr1256569ejg.21.1703327146994; Sat, 23 Dec 2023 02:25:46 -0800 (PST) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id ex17-20020a170907955100b00a269fa0d305sm2923466ejc.8.2023.12.23.02.25.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Dec 2023 02:25:46 -0800 (PST) Message-ID: Date: Sat, 23 Dec 2023 11:25:45 +0100 Precedence: bulk X-Mailing-List: linux-kernel-mentees@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] staging: media: atomisp: pci: Fix spelling mistake in ia_css_acc_types.h To: Randy Dunlap , Dipendra Khadka , mchehab@kernel.org, sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org, hpa@redhat.com Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org References: <20231223051108.74711-1-kdipendra88@gmail.com> From: Hans de Goede In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US, nl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 12/23/23 06:18, Randy Dunlap wrote: > Hi Dipendra, > > On 12/22/23 21:11, Dipendra Khadka wrote: >> codespell reported spelling mistakes in >> ia_css_acc_types.h as below: >> >> ''' >> ia_css_acc_types.h:87: cummulative ==> cumulative >> ia_css_acc_types.h:411: descibes ==> describes >> ''' >> >> This patch fixes these spelling mistakes. >> >> Signed-off-by: Dipendra Khadka > > This patch is an improvement so it could be merged as is IMO. > But... > >> --- >> v2: >> - Previously only corrected spelling mistake reported by checkpatch.pl. >> - All spelling mistakes reported by codespell are fixed. >> v1: https://lore.kernel.org/lkml/20231222200350.2024-1-kdipendra88@gmail.com/ >> >> drivers/staging/media/atomisp/pci/ia_css_acc_types.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/staging/media/atomisp/pci/ia_css_acc_types.h b/drivers/staging/media/atomisp/pci/ia_css_acc_types.h >> index d6e52b4971d6..1dc2085ecd61 100644 >> --- a/drivers/staging/media/atomisp/pci/ia_css_acc_types.h >> +++ b/drivers/staging/media/atomisp/pci/ia_css_acc_types.h >> @@ -84,7 +84,7 @@ struct ia_css_blob_info { >> memory_offsets; /** offset wrt hdr in bytes */ >> u32 prog_name_offset; /** offset wrt hdr in bytes */ >> u32 size; /** Size of blob */ >> - u32 padding_size; /** total cummulative of bytes added due to section alignment */ >> + u32 padding_size; /** total cumulative of bytes added due to section alignment */ > > I apologize for not looking at your v1 patch carefully. > The comment above would be much better as > > /** total accumulation of bytes added due to section alignment */ I agree that that is better. Dipendra can you please send a v3 using the new text suggested by Randy ? Regards, Hans >> u32 icache_source; /** Position of icache in blob */ >> u32 icache_size; /** Size of icache section */ >> u32 icache_padding;/** bytes added due to icache section alignment */ >> @@ -408,7 +408,7 @@ struct ia_css_acc_sp { >> }; >> >> /* Acceleration firmware descriptor. >> - * This descriptor descibes either SP code (stand-alone), or >> + * This descriptor describes either SP code (stand-alone), or >> * ISP code (a separate pipeline stage). >> */ >> struct ia_css_acc_fw_hdr { >