From: Yunsheng Lin <linyunsheng@huawei.com>
To: Jason Wang <jasowang@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <brouer@redhat.com>,
<paulmck@kernel.org>, <peterz@infradead.org>, <will@kernel.org>,
<shuah@kernel.org>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
<linuxarm@openeuler.org>
Subject: Re: [PATCH net-next v3 1/3] selftests/ptr_ring: add benchmark application for ptr_ring
Date: Fri, 2 Jul 2021 17:54:42 +0800 [thread overview]
Message-ID: <06f0dc67-d614-30d3-6dcc-f2446cb6030b@huawei.com> (raw)
In-Reply-To: <1fed53f1-f882-ca67-8876-ca6702dcd9cd@redhat.com>
On 2021/7/2 17:04, Jason Wang wrote:
>
[...]
>
>
>> I understand that you guys like to see a working testcase of virtio.
>> I would love to do that if I have the time and knowledge of virtio,
>> But I do not think I have the time and I am familiar enough with
>> virtio to fix that now.
>
>
> So ringtest is used for bench-marking the ring performance for different format. Virtio is only one of the supported ring format, ptr ring is another. Wrappers were used to reuse the same test logic.
>
> Though you may see host/guest in the test, it's in fact done via two processes.
>
> We need figure out:
>
> 1) why the current ringtest.c does not fit for your requirement (it has SPSC test)
There is MPSC case used by pfifo_fast, it make more sense to use a separate selftest
for ptr_ring as ptr_ring has been used by various subsystems.
> 2) why can't we tweak the ptr_ring.c to be used by both ring_test and your benchmark
Actually that is what I do in this patch, move the specific part related to ptr_ring
to ptr_ring_test.h. When the virtio testing is refactored to work, it can reuse the
abstract layer in ptr_ring_test.h too.
>
> If neither of the above work, we can invent new ptr_ring infrastructure under tests/
>
> Thanks
>
>
>>
>>
>
> .
>
next prev parent reply other threads:[~2021-07-02 9:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 12:26 [PATCH net-next v3 0/3] add benchmark selftest and optimization for ptr_ring Yunsheng Lin
2021-07-01 12:26 ` [PATCH net-next v3 1/3] selftests/ptr_ring: add benchmark application " Yunsheng Lin
2021-07-02 6:43 ` Jason Wang
2021-07-02 8:17 ` Yunsheng Lin
2021-07-02 8:30 ` Michael S. Tsirkin
2021-07-02 8:46 ` Yunsheng Lin
2021-07-02 9:04 ` Jason Wang
2021-07-02 9:54 ` Yunsheng Lin [this message]
2021-07-02 14:18 ` Michael S. Tsirkin
2021-07-05 1:43 ` Yunsheng Lin
2021-07-02 14:16 ` Michael S. Tsirkin
2021-07-01 12:26 ` [PATCH net-next v3 2/3] ptr_ring: move r->queue[] clearing after r->consumer_head updating Yunsheng Lin
2021-07-02 6:45 ` Jason Wang
2021-07-02 8:40 ` [Linuxarm] " Yunsheng Lin
2021-07-01 12:26 ` [PATCH net-next v3 3/3] ptr_ring: add barrier to ensure the visiblity of r->queue[] Yunsheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06f0dc67-d614-30d3-6dcc-f2446cb6030b@huawei.com \
--to=linyunsheng@huawei.com \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).