From: shuah <shuah@kernel.org>
To: Eugene Syromiatnikov <esyr@redhat.com>,
linux-kernel@vger.kernel.org,
Christian Brauner <christian@brauner.io>,
linux-kselftest@vger.kernel.org
Cc: Adrian Reber <areber@redhat.com>, shuah <shuah@kernel.org>
Subject: Re: [PATCH 3/6] selftests/clone3: use uint64_t for flags parameter
Date: Mon, 16 Sep 2019 10:40:25 -0600 [thread overview]
Message-ID: <1b15fe21-76d9-a858-08a8-02e19afc6b11@kernel.org> (raw)
In-Reply-To: <3f7bd9f0446360f90f12b9e9d3af1de2f5133a81.1568116761.git.esyr@redhat.com>
On 9/10/19 6:03 AM, Eugene Syromiatnikov wrote:
> Flags parameter in both userspace and kernel clone args is 64-bit wide,
> there's little reason to have it signed and 32-bit in tests.
>
So what are doing? You are stating the problem here, how are you
fixing it?
> * tools/testing/selftests/clone3/clone3.c: Include <inttypes.h> and
> <stdint.h>.
> (call_clone3): Change flags parameter type from int to uint64_t.
> (test_clone3): Change flags parameter type from int to uint64_t; change
> the format string that prints it accordingly.
>
I am not going to say this again. Please don't include pseudo code in
the commit log.
> Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
> ---
> tools/testing/selftests/clone3/clone3.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/clone3/clone3.c b/tools/testing/selftests/clone3/clone3.c
> index 4f23a0c..1746a9b 100644
> --- a/tools/testing/selftests/clone3/clone3.c
> +++ b/tools/testing/selftests/clone3/clone3.c
> @@ -4,8 +4,10 @@
>
> #define _GNU_SOURCE
> #include <errno.h>
> +#include <inttypes.h>
> #include <linux/types.h>
> #include <linux/sched.h>
> +#include <stdint.h>
> #include <stdio.h>
> #include <stdlib.h>
> #include <sys/syscall.h>
> @@ -36,7 +38,7 @@ static pid_t raw_clone(struct clone_args *args, size_t size)
> return syscall(__NR_clone3, args, size);
> }
>
> -static int call_clone3(int flags, size_t size, enum test_mode test_mode)
> +static int call_clone3(uint64_t flags, size_t size, enum test_mode test_mode)
> {
> struct clone_args args = {0};
> pid_t ppid = -1;
> @@ -102,12 +104,13 @@ static int call_clone3(int flags, size_t size, enum test_mode test_mode)
> return 0;
> }
>
> -static int test_clone3(int flags, size_t size, int expected,
> +static int test_clone3(uint64_t flags, size_t size, int expected,
> enum test_mode test_mode)
> {
> int ret;
>
> - ksft_print_msg("[%d] Trying clone3() with flags 0x%x (size %d)\n",
> + ksft_print_msg("[%d] Trying clone3() with flags %#" PRIx64 " (size %d)"
> + "\n",
> getpid(), flags, size);
> ret = call_clone3(flags, size, test_mode);
> ksft_print_msg("[%d] clone3() with flags says :%d expected %d\n",
>
thanks,
-- Shuah
next prev parent reply other threads:[~2019-09-16 16:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 12:02 [PATCH 0/6] Update clone3 self-tests Eugene Syromiatnikov
2019-09-10 12:03 ` [PATCH 1/6] selftests/clone3: convert test modes into an enum Eugene Syromiatnikov
2019-09-16 16:28 ` shuah
2019-09-10 12:03 ` [PATCH 2/6] selftests/clone3: add a check for invalid exit_signal Eugene Syromiatnikov
2019-09-16 16:37 ` shuah
2019-09-10 12:03 ` [PATCH 3/6] selftests/clone3: use uint64_t for flags parameter Eugene Syromiatnikov
2019-09-16 16:40 ` shuah [this message]
2019-09-10 12:03 ` [PATCH 4/6] selftests/clone3: fix up format strings Eugene Syromiatnikov
2019-09-16 16:41 ` shuah
2019-09-10 12:03 ` [PATCH 5/6] selftests/clone3: enable clone3 self-tests on all architectures Eugene Syromiatnikov
2019-09-16 16:44 ` shuah
2019-09-10 12:03 ` [PATCH 6/6] selftests: add clone3 to TARGETS Eugene Syromiatnikov
2019-09-16 16:48 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b15fe21-76d9-a858-08a8-02e19afc6b11@kernel.org \
--to=shuah@kernel.org \
--cc=areber@redhat.com \
--cc=christian@brauner.io \
--cc=esyr@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).