From: Mat Martineau <mathew.j.martineau@linux.intel.com>
To: Matthieu Baerts <matthieu.baerts@tessares.net>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Shuah Khan <shuah@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
netdev@vger.kernel.org, mptcp@lists.01.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] selftests: mptcp: depends on built-in IPv6
Date: Wed, 21 Oct 2020 17:35:32 -0700 (PDT) [thread overview]
Message-ID: <1d28e7da-3fce-b064-a159-662f53e5a3b@linux.intel.com> (raw)
In-Reply-To: <20201021155549.933731-1-matthieu.baerts@tessares.net>
On Wed, 21 Oct 2020, Matthieu Baerts wrote:
> Recently, CONFIG_MPTCP_IPV6 no longer selects CONFIG_IPV6. As a
> consequence, if CONFIG_MPTCP_IPV6=y is added to the kconfig, it will no
> longer ensure CONFIG_IPV6=y. If it is not enabled, CONFIG_MPTCP_IPV6
> will stay disabled and selftests will fail.
>
> We also need CONFIG_IPV6 to be built-in. For more details, please see
> commit 0ed37ac586c0 ("mptcp: depends on IPV6 but not as a module").
>
> Note that 'make kselftest-merge' will take all 'config' files found in
> 'tools/testsing/selftests'. Because some of them already set
> CONFIG_IPV6=y, MPTCP selftests were still passing. But they will fail if
> MPTCP selftests are launched manually after having executed this command
> to prepare the kernel config:
>
> ./scripts/kconfig/merge_config.sh -m .config \
> ./tools/testing/selftests/net/mptcp/config
>
> Fixes: 010b430d5df5 ("mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it")
> Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
> ---
> tools/testing/selftests/net/mptcp/config | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
--
Mat Martineau
Intel
next prev parent reply other threads:[~2020-10-22 0:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 15:55 [PATCH net] selftests: mptcp: depends on built-in IPv6 Matthieu Baerts
2020-10-22 0:35 ` Mat Martineau [this message]
2020-10-22 3:43 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d28e7da-3fce-b064-a159-662f53e5a3b@linux.intel.com \
--to=mathew.j.martineau@linux.intel.com \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=matthieu.baerts@tessares.net \
--cc=mptcp@lists.01.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).