From: Greg KH <gregkh@linuxfoundation.org>
To: Christian Clauss <cclauss@me.com>
Cc: linux-kselftest@vger.kernel.org
Subject: Re: Fixing Python 3 syntax errors in tpm2_tests.py
Date: Tue, 18 Jun 2019 08:23:09 +0200 [thread overview]
Message-ID: <20190618062309.GB8506@kroah.com> (raw)
In-Reply-To: <B021B4EF-903E-4EA2-9B2B-0B0301D28DE7@me.com>
On Mon, Jun 17, 2019 at 11:28:34PM +0200, Christian Clauss wrote:
> Hello,
>
> As my very first contribution to the Linux Kernel, I would like to fix six Python 3 syntax errors in the file ./tools/testing/selftests/tpm2/tpm2_tests.py
>
> All six of these errors are of the same form: except ProtocolError, e: To fix the syntax errors, I propose to change the comma (,) to “as” like: except ProtocolError as e:
>
> These changes are important because the current form is compatible with Python 2 but is a syntax error in Python 3. The proposed form is compatible with both Python 2 and Python3. This conversion is required because Python 2 will reach its end of life in less than 200 days.
>
> The kernel contains at least five other files where I am able to detect Python 3 syntax errors but after studying in detail the process of making kernel modification, I believe that it is best to start with tpm2_tests.py because the changes are straightforward and uncontroversial — all issues are of the same form, and I can detect no other issues (such as undefined names) to fix in that file.
>
> If I succeed in getting the modifications to tpm2_tests.py through the review process then I can try the remaining files in turn.
>
> I would be interested to know if this is a worthwhile effort. Is there already another initiative to resolve these issue before yearend?
Just send patches, and we will be glad to review them as-is. No need to
ask permission ahead of time, we do not "reserve" tasks for people.
thanks,
greg k-h
prev parent reply other threads:[~2019-06-18 6:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 21:28 Fixing Python 3 syntax errors in tpm2_tests.py Christian Clauss
2019-06-18 6:23 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618062309.GB8506@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=cclauss@me.com \
--cc=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).