From: Kees Cook <keescook@chromium.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
jaswinder.singh@linaro.org,
Jun Takahashi <takahashi.jun_s@aa.socionext.com>
Subject: Re: [BUGFIX PATCH] selftests: breakpoints: Fix a typo of function name
Date: Thu, 31 Oct 2019 08:58:32 -0700 [thread overview]
Message-ID: <201910310857.81DFF3A6@keescook> (raw)
In-Reply-To: <157252457993.20908.6741530756091861014.stgit@devnote2>
On Thu, Oct 31, 2019 at 09:23:00PM +0900, Masami Hiramatsu wrote:
> Since commit 5821ba969511 ("selftests: Add test plan API to kselftest.h
> and adjust callers") accidentally introduced 'a' typo in the front of
> run_test() function, breakpoint_test_arm64.c became not able to be
> compiled.
>
> Remove the 'a' from arun_test().
>
> Fixes: 5821ba969511 ("selftests: Add test plan API to kselftest.h and adjust callers")
> Reported-by: Jun Takahashi <takahashi.jun_s@aa.socionext.com>
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> Cc: Kees Cook <keescook@chromium.org>
Argh, apologies! Yes, thank you for catching this.
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> .../selftests/breakpoints/breakpoint_test_arm64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c b/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
> index 58ed5eeab709..ad41ea69001b 100644
> --- a/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
> +++ b/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
> @@ -109,7 +109,7 @@ static bool set_watchpoint(pid_t pid, int size, int wp)
> return false;
> }
>
> -static bool arun_test(int wr_size, int wp_size, int wr, int wp)
> +static bool run_test(int wr_size, int wp_size, int wr, int wp)
> {
> int status;
> siginfo_t siginfo;
>
--
Kees Cook
prev parent reply other threads:[~2019-10-31 15:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 12:23 [BUGFIX PATCH] selftests: breakpoints: Fix a typo of function name Masami Hiramatsu
2019-10-31 15:58 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201910310857.81DFF3A6@keescook \
--to=keescook@chromium.org \
--cc=jaswinder.singh@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=shuah@kernel.org \
--cc=takahashi.jun_s@aa.socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).