From: Aleksa Sarai <cyphar@cyphar.com>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Jeff Layton <jlayton@kernel.org>,
"J. Bruce Fields" <bfields@fieldses.org>,
Shuah Khan <shuah@kernel.org>,
Florian Weimer <fweimer@redhat.com>,
David Laight <david.laight@aculab.com>,
dev@opencontainers.org, containers@lists.linux-foundation.org,
libc-alpha@sourceware.org, linux-api@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 0/2] openat2: minor uapi cleanups
Date: Fri, 20 Dec 2019 00:41:17 +1100 [thread overview]
Message-ID: <20191219134117.cd2vlgudkzke2koa@yavin.dot.cyphar.com> (raw)
In-Reply-To: <20191219111949.auriw6biphxxvdng@wittgenstein>
[-- Attachment #1: Type: text/plain, Size: 1246 bytes --]
On 2019-12-19, Christian Brauner <christian.brauner@ubuntu.com> wrote:
> On Thu, Dec 19, 2019 at 09:55:28PM +1100, Aleksa Sarai wrote:
> > While openat2(2) is still not yet in Linus's tree, we can take this
> > opportunity to iron out some small warts that weren't noticed earlier:
> >
> > * A fix was suggested by Florian Weimer, to separate the openat2
> > definitions so glibc can use the header directly. I've put the
> > maintainership under VFS but let me know if you'd prefer it belong
> > ot the fcntl folks.
> >
> > * Having heterogenous field sizes in an extensible struct results in
> > "padding hole" problems when adding new fields (in addition the
> > correct error to use for non-zero padding isn't entirely clear ).
> > The simplest solution is to just copy clone(3)'s model -- always use
> > u64s. It will waste a little more space in the struct, but it
> > removes a possible future headache.
>
> Am I imagining things or did I get the same patch series twice?
Not unless it's a coincidence -- I accidentally ran
% git send-email *.patch [some flags] *.patch
--
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2019-12-19 13:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 10:55 [PATCH 0/2] openat2: minor uapi cleanups Aleksa Sarai
2019-12-19 10:55 ` [PATCH 1/2] uapi: split openat2(2) definitions from fcntl.h Aleksa Sarai
2019-12-19 11:07 ` Florian Weimer
2019-12-19 13:45 ` Aleksa Sarai
2019-12-19 14:05 ` David Laight
2019-12-20 9:31 ` Aleksa Sarai
2019-12-20 10:18 ` David Laight
2019-12-19 10:55 ` [PATCH 2/2] openat2: drop open_how->__padding field Aleksa Sarai
2019-12-19 11:18 ` Christian Brauner
2019-12-19 10:55 ` [PATCH 0/2] openat2: minor uapi cleanups Aleksa Sarai
2019-12-19 10:55 ` [PATCH 1/2] uapi: split openat2(2) definitions from fcntl.h Aleksa Sarai
2019-12-19 10:55 ` [PATCH 2/2] openat2: drop open_how->__padding field Aleksa Sarai
2019-12-19 11:19 ` [PATCH 0/2] openat2: minor uapi cleanups Christian Brauner
2019-12-19 13:41 ` Aleksa Sarai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219134117.cd2vlgudkzke2koa@yavin.dot.cyphar.com \
--to=cyphar@cyphar.com \
--cc=bfields@fieldses.org \
--cc=christian.brauner@ubuntu.com \
--cc=containers@lists.linux-foundation.org \
--cc=david.laight@aculab.com \
--cc=dev@opencontainers.org \
--cc=fweimer@redhat.com \
--cc=jlayton@kernel.org \
--cc=libc-alpha@sourceware.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).