From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F589C33C8C for ; Tue, 7 Jan 2020 14:56:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 027E2222D9 for ; Tue, 7 Jan 2020 14:56:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bUFCjzqC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728115AbgAGO4S (ORCPT ); Tue, 7 Jan 2020 09:56:18 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:33652 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727908AbgAGO4S (ORCPT ); Tue, 7 Jan 2020 09:56:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578408977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AMsY+5AfULXXQPieaO9m1OwQcv8Xr5ZMsyyOrT8Fw9k=; b=bUFCjzqC7th5UypWPVL/1R7VapYKerroS15saH+gE4GAJK5OEumhVeq5moKrYVC2LvXkpt GWc5BgGELct9Hj8cJShD1lRICmmLYbMwU/yaI0Mp7fLa07ZwLHvqta7LRB8wisGgwxgNEX E5UT1V0IyVvZbPqegwgoXUScMnL9mLw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-330-2BCXJcVsMTWMhcag17A0mg-1; Tue, 07 Jan 2020 09:56:15 -0500 X-MC-Unique: 2BCXJcVsMTWMhcag17A0mg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 49303100550E; Tue, 7 Jan 2020 14:56:14 +0000 (UTC) Received: from kamzik.brq.redhat.com (unknown [10.43.2.160]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CDB4C5D9CA; Tue, 7 Jan 2020 14:56:10 +0000 (UTC) Date: Tue, 7 Jan 2020 15:56:08 +0100 From: Andrew Jones To: Peter Xu Cc: Ben Gardon , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, Paolo Bonzini , Cannon Matthews Subject: Re: [PATCH v3 1/8] KVM: selftests: Create a demand paging test Message-ID: <20200107145608.ogi34nkyh2abdgrq@kamzik.brq.redhat.com> References: <20191216213901.106941-1-bgardon@google.com> <20191216213901.106941-2-bgardon@google.com> <20200107143334.GF219677@xz-x1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200107143334.GF219677@xz-x1> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Tue, Jan 07, 2020 at 09:33:34AM -0500, Peter Xu wrote: > On Mon, Dec 16, 2019 at 01:38:54PM -0800, Ben Gardon wrote: > > While userfaultfd, KVM's demand paging implementation, is not specific > > to KVM, having a benchmark for its performance will be useful for > > guiding performance improvements to KVM. As a first step towards creating > > a userfaultfd demand paging test, create a simple memory access test, > > based on dirty_log_test. > > > > Signed-off-by: Ben Gardon > > It's fine to start with x86-only for this test, but imho it would be > better to mention that in cover letter, or reply to reviewer comments > on that you removed aarch64 from previous post. I'd also prefer that if it's x86-only that it be put in the x86_64 subdirectory and drop the arch #ifdefs. The question is why is it x86-only for now though? Will it take a lot of work to port it to other architectures? Or does it just need testing by someone with the hardware? Thanks, drew