From: Steven Rostedt <rostedt@goodmis.org>
To: shuah@kernel.org
Cc: Alan Maguire <alan.maguire@oracle.com>,
mhiramat@kernel.org, mingo@redhat.com,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] ftrace/selftest: clean up failure cases
Date: Wed, 19 Feb 2020 14:26:27 -0500 [thread overview]
Message-ID: <20200219142627.716090a0@gandalf.local.home> (raw)
In-Reply-To: <1582104810-12983-1-git-send-email-alan.maguire@oracle.com>
Shuah,
Can you take these two patches through your tree?
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
On Wed, 19 Feb 2020 09:33:28 +0000
Alan Maguire <alan.maguire@oracle.com> wrote:
> When running the ftrace selftests, 2 failures and 6 unresolved
> cases were observed. The failures can be avoided by setting
> a sysctl prior to test execution (fixed in patch 1) and by
> having unresolved cases not return 0 from ftracetest by default
> since they indicate an absence of testing modules/programs
> rather than ftrace issues (patch 2).
>
> The latter are classified as "unresolved" tests, which operate
> differently from "unsupported" tests. For unsupported tests,
> we note the unsupported count but do not consider the tests
> as having failed, whereas with unresolved the test run is
> considered to have failed so returns "not ok" when run via
> kselftest ("make -C tools/testing/selftest/ftrace run_tests").
>
> Patch 2 aligns the unresolved behaviour with the unsupported;
> by default, unresolved outcomes do not trigger overall failure,
> but they can if --fail-unresolved is specified.
>
> Changes since v1:
>
> - updated patch 1 to use /proc path instead of sysctl (Masami)
> - updated patch 2 to modify unresolved handling in ftracetest
> rather than change individual unresolved -> unsupported (Masami)
>
> Alan Maguire (2):
> ftrace/selftests: workaround cgroup RT scheduling issues
> ftrace/selftest: make unresolved cases cause failure if
> --fail-unresolved set
>
> tools/testing/selftests/ftrace/ftracetest | 30 +++++++++++++++++++++++++++++-
> 1 file changed, 29 insertions(+), 1 deletion(-)
>
prev parent reply other threads:[~2020-02-19 19:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 9:33 [PATCH v2 0/2] ftrace/selftest: clean up failure cases Alan Maguire
2020-02-19 9:33 ` [PATCH v2 1/2] ftrace/selftests: workaround cgroup RT scheduling issues Alan Maguire
2020-02-19 9:33 ` [PATCH v2 2/2] ftrace/selftest: make unresolved cases cause failure if --fail-unresolved set Alan Maguire
2020-02-19 11:39 ` Masami Hiramatsu
2020-05-01 9:42 ` Masami Hiramatsu
2020-05-01 14:25 ` shuah
2020-05-02 4:42 ` Masami Hiramatsu
2020-02-19 19:26 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219142627.716090a0@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=alan.maguire@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).