From: Mark Brown <broonie@kernel.org>
To: shuah <shuah@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 2/3] selftests: vdso: Use a header file to prototype parse_vdso API
Date: Tue, 19 May 2020 18:42:44 +0100 [thread overview]
Message-ID: <20200519174244.GQ4611@sirena.org.uk> (raw)
In-Reply-To: <aaeb0619-68d2-18f8-f72a-b8b37f348b4e@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
On Tue, May 19, 2020 at 11:29:10AM -0600, shuah wrote:
> On 5/5/20 11:47 AM, Mark Brown wrote:
> > - * These are the prototypes:
> > - */
> > -extern void vdso_init_from_auxv(void *auxv);
> > -extern void vdso_init_from_sysinfo_ehdr(uintptr_t base);
> > -extern void *vdso_sym(const char *version, const char *name);
> > + * These are the prototypes:
> > + */
> > +extern void *vdso_sym(const char *version, const char *name);
> > +extern void vdso_init_from_sysinfo_ehdr(uintptr_t base);
> > +extern void vdso_init_from_auxv(void *auxv);
> You don't need extern here - this should be in scope?
This is just code motion of existing code which has the externs.
There's no cases where you *need* the extern, it's just syntactic sugar.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-05-19 17:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 17:47 [PATCH 0/3] selftests: vdso: Add a selftest for vDSO getcpu() Mark Brown
2020-05-05 17:47 ` [PATCH 1/3] selftests: vdso: Rename vdso_test to vdso_test_gettimeofday Mark Brown
2020-05-05 17:47 ` [PATCH 2/3] selftests: vdso: Use a header file to prototype parse_vdso API Mark Brown
2020-05-19 17:29 ` shuah
2020-05-19 17:42 ` Mark Brown [this message]
2020-05-05 17:47 ` [PATCH 3/3] selftests: vdso: Add a selftest for vDSO getcpu() Mark Brown
2020-05-19 17:11 ` shuah
2020-05-19 17:44 ` Mark Brown
2020-05-22 14:55 ` shuah
2020-05-22 15:12 ` Mark Brown
2020-05-22 15:15 ` shuah
2020-05-22 16:15 ` Mark Brown
2020-05-05 18:17 ` [PATCH 0/3] " shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519174244.GQ4611@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).