On Fri, May 22, 2020 at 08:55:50AM -0600, shuah wrote: > On 5/19/20 11:44 AM, Mark Brown wrote: > > > WARNING: Missing a blank line after declarations > > > WARNING: Missing a blank line after declarations > > > #135: FILE: tools/testing/selftests/vDSO/vdso_test_getcpu.c:27: > > > + unsigned long sysinfo_ehdr = getauxval(AT_SYSINFO_EHDR); > A blank line after declarations here just like what checkpatch > suggests. It makes it readable. That doesn't match the idiom used by any of the surrounding code :(