From: Marcelo Tosatti <mtosatti@redhat.com>
To: "Moessbauer, Felix" <felix.moessbauer@siemens.com>
Cc: "Michal Koutný" <mkoutny@suse.com>,
"longman@redhat.com" <longman@redhat.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
"corbet@lwn.net" <corbet@lwn.net>,
"frederic@kernel.org" <frederic@kernel.org>,
"guro@fb.com" <guro@fb.com>,
"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
"juri.lelli@redhat.com" <juri.lelli@redhat.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"lizefan.x@bytedance.com" <lizefan.x@bytedance.com>,
"pauld@redhat.com" <pauld@redhat.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"shuah@kernel.org" <shuah@kernel.org>,
"tj@kernel.org" <tj@kernel.org>,
"jan.kiszka@siemens.com" <jan.kiszka@siemens.com>,
"henning.schild@siemens.com" <henning.schild@siemens.com>
Subject: Re: [PATCH v8 0/6] cgroup/cpuset: Add new cpuset partition type & empty effecitve cpus
Date: Wed, 10 Nov 2021 13:14:29 -0300 [thread overview]
Message-ID: <20211110161429.GA22855@fuller.cnet> (raw)
In-Reply-To: <20211110161020.GA20101@fuller.cnet>
On Wed, Nov 10, 2021 at 01:10:20PM -0300, Marcelo Tosatti wrote:
> On Wed, Nov 10, 2021 at 03:21:54PM +0000, Moessbauer, Felix wrote:
> >
> >
> > > -----Original Message-----
> > > From: Michal Koutný <mkoutny@suse.com>
> > > Sent: Wednesday, November 10, 2021 2:57 PM
> > > To: Moessbauer, Felix (T RDA IOT SES-DE) <felix.moessbauer@siemens.com>
> > > Cc: longman@redhat.com; akpm@linux-foundation.org;
> > > cgroups@vger.kernel.org; corbet@lwn.net; frederic@kernel.org; guro@fb.com;
> > > hannes@cmpxchg.org; juri.lelli@redhat.com; linux-doc@vger.kernel.org; linux-
> > > kernel@vger.kernel.org; linux-kselftest@vger.kernel.org;
> > > lizefan.x@bytedance.com; mtosatti@redhat.com; pauld@redhat.com;
> > > peterz@infradead.org; shuah@kernel.org; tj@kernel.org; Kiszka, Jan (T RDA
> > > IOT) <jan.kiszka@siemens.com>; Schild, Henning (T RDA IOT SES-DE)
> > > <henning.schild@siemens.com>
> > > Subject: Re: [PATCH v8 0/6] cgroup/cpuset: Add new cpuset partition type &
> > > empty effecitve cpus
> > >
> > > Hello.
> > >
> > > On Wed, Nov 10, 2021 at 12:13:57PM +0100, Felix Moessbauer
> > > <felix.moessbauer@siemens.com> wrote:
> > > > However, I was not able to see any latency improvements when using
> > > > cpuset.cpus.partition=isolated.
> > >
> > > Interesting. What was the baseline against which you compared it (isolcpus, no
> > > cpusets,...)?
> >
> > For this test, I just compared both settings cpuset.cpus.partition=isolated|root.
> > There, I did not see a significant difference (but I know, RT tuning depends on a ton of things).
> >
> > >
> > > > The test was performed with jitterdebugger on CPUs 1-3 and the following
> > > cmdline:
> > > > rcu_nocbs=1-4 nohz_full=1-4 irqaffinity=0,5-6,11 intel_pstate=disable
> > > > On the other cpus, stress-ng was executed to generate load.
> > > > [...]
> > >
> > > > This requires cgroup.type=threaded on both cgroups and changes to the
> > > > application (threads have to be born in non-rt group and moved to rt-group).
> > >
> > > But even with isolcpus the application would need to set affinity of threads to
> > > the selected CPUs (cf cgroup migrating). Do I miss anything?
> >
> > Yes, that's true. But there are two differences (given that you use isolcpus):
> > 1. the application only has to set the affinity for rt threads.
> > Threads that do not explicitly set the affinity are automatically excluded from the isolated cores.
> > Even common rt test applications like jitterdebugger do not pin their non-rt threads.
> > 2. Threads can be started on non-rt CPUs and then bound to a specific rt CPU.
> > This binding can be specified before thread creation via pthread_create.
> > By that, you can make sure that at no point in time a thread has a "forbidden" CPU in its affinities.
> >
> > With cgroup2, you cannot guarantee the second aspect, as thread creation and moving to a cgroup is not an atomic operation.
> > Also - please correct me if I'm wrong - you first have to create a thread before moving it into a group.
> > At creation time, you cannot set the final affinity mask (as you create it in the non-rt group and there the CPU is not in the cpuset.cpus).
> > Once you move the thread to the rt cgroup, it has a default mask and by that can be executed on other rt cores.
>
> man clone3:
>
> CLONE_NEWCGROUP (since Linux 4.6)
> Create the process in a new cgroup namespace. If this flag is not set, then (as with fork(2)) the
> process is created in the same cgroup namespaces as the calling process.
>
> For further information on cgroup namespaces, see cgroup_namespaces(7).
>
> Only a privileged process (CAP_SYS_ADMIN) can employ CLONE_NEWCGROUP.
>
Err, CLONE_INTO_CGROUP.
next prev parent reply other threads:[~2021-11-10 16:15 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 14:36 [PATCH v8 0/6] cgroup/cpuset: Add new cpuset partition type & empty effecitve cpus Waiman Long
2021-10-18 14:36 ` [PATCH v8 1/6] cgroup/cpuset: Allow no-task partition to have empty cpuset.cpus.effective Waiman Long
2021-10-18 14:36 ` [PATCH v8 2/6] cgroup/cpuset: Refining features and constraints of a partition Waiman Long
2021-10-18 14:36 ` [PATCH v8 3/6] cgroup/cpuset: Add a new isolated cpus.partition type Waiman Long
2021-10-18 14:36 ` [PATCH v8 4/6] cgroup/cpuset: Show invalid partition reason string Waiman Long
2021-10-18 14:36 ` [PATCH v8 5/6] cgroup/cpuset: Update description of cpuset.cpus.partition in cgroup-v2.rst Waiman Long
2021-11-15 19:31 ` Michal Koutný
2021-11-15 20:11 ` Tejun Heo
2021-11-15 21:27 ` Waiman Long
2021-11-15 21:10 ` Waiman Long
2021-11-16 17:54 ` Michal Koutný
2021-11-30 15:35 ` Waiman Long
2021-11-30 17:11 ` Tejun Heo
2021-12-01 3:56 ` Waiman Long
2021-12-01 14:13 ` Michal Koutný
2021-12-01 14:56 ` Waiman Long
2021-12-01 16:39 ` Tejun Heo
2021-12-01 17:49 ` Waiman Long
2021-12-01 14:26 ` Waiman Long
2021-12-01 16:46 ` Tejun Heo
2021-12-01 18:05 ` Waiman Long
2021-12-02 1:28 ` Waiman Long
2021-12-03 18:25 ` Michal Koutný
2021-12-03 19:27 ` Waiman Long
2021-10-18 14:36 ` [PATCH v8 6/6] kselftest/cgroup: Add cpuset v2 partition root state test Waiman Long
2021-10-27 23:05 ` [PATCH v8 0/6] cgroup/cpuset: Add new cpuset partition type & empty effecitve cpus Waiman Long
2021-11-10 11:13 ` Felix Moessbauer
2021-11-10 13:21 ` Marcelo Tosatti
2021-11-10 13:56 ` Michal Koutný
2021-11-10 15:21 ` Moessbauer, Felix
2021-11-10 16:10 ` Marcelo Tosatti
2021-11-10 16:14 ` Marcelo Tosatti [this message]
2021-11-10 16:15 ` Jan Kiszka
2021-11-10 17:29 ` Marcelo Tosatti
2021-11-10 18:30 ` Waiman Long
2021-11-10 17:52 ` Michal Koutný
2021-11-10 18:04 ` Jan Kiszka
2021-11-10 18:15 ` Michal Koutný
2021-11-10 15:20 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211110161429.GA22855@fuller.cnet \
--to=mtosatti@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=felix.moessbauer@siemens.com \
--cc=frederic@kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=henning.schild@siemens.com \
--cc=jan.kiszka@siemens.com \
--cc=juri.lelli@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=mkoutny@suse.com \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).