From: Shuah Khan <skhan@linuxfoundation.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Michal Marek <michal.lkml@markovi.net>,
"Cc: Shuah Khan" <shuah@kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"skh >> Shuah Khan" <skhan@linuxfoundation.org>
Subject: Re: [PATCH 2/2] selftests: Add kselftest_install target to main Makefile
Date: Thu, 26 Sep 2019 16:11:36 -0600 [thread overview]
Message-ID: <43a7962e-4fae-78e4-1db2-b75c7ff802b1@linuxfoundation.org> (raw)
In-Reply-To: <CAK7LNATCFF9ERTwtPnnbMLGv++NJ_5zXxB0=NWHdSGrYADj3ug@mail.gmail.com>
On 9/25/19 9:24 PM, Masahiro Yamada wrote:
> Hi Shuah,
>
>
>
> On Thu, Sep 26, 2019 at 8:05 AM Shuah Khan <skhan@linuxfoundation.org> wrote:
>>
>> Add kselftest_install target to install tests from the top level
>> Makefile. This is to simplify kselftest use-cases for CI and
>> distributions where build and test systems are different.
>>
>> This change addresses requests from developers and testers to add
>> support for installing kselftest from the main Makefile.
>>
>> In addition, make the install directory the same when install is
>> run using "make kselftest_install" or by running kselftest_install.sh.
>> Also fix the INSTALL_PATH variable conflict between main Makefile.
>>
>> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
>
> So, if these two patches were applied, we would see the following:
>
>
> PHONY += kselftest_build
> kselftest_build:
> $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests all
>
> PHONY += kselftest
> kselftest:
> $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests run_tests
>
> PHONY += kselftest_install
> kselftest_install:
> $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests install
>
> PHONY += kselftest-clean
> kselftest-clean:
> $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests clean
>
>
> I do not want to see this endless crap addition just for
> changing the working directory to $(srctree)/tools/testing/selftests
>
>
>
> Why don't you use pattern rule?
> Those will be reduced into the two rules.
>
I just didn't think about simplifying it. Thanks for
being direct.
>
>
> PHONY += kselftest
> kselftest:
> $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests run_tests
>
> kselftest-%: FORCE
> $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests $*
>
>
>
> This also avoids your inconsistency about
> "kselftest-" vs "kselftest_".
>
>
> Given the existing "kselftest-clean" and "kselftest-merge",
> "kselftest_build" and "kselftest_install"
> (using an underscore instead of n hyphen)
> would add needless confusion.
>
>
Done. Sending v2 with two patches collapsed into one.
thanks,
-- Shuah
prev parent reply other threads:[~2019-09-26 22:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 23:04 [PATCH 0/2] Simplify kselftest build and install use-cases Shuah Khan
2019-09-25 23:04 ` [PATCH 1/2] Makefile: Add kselftest_build target to build tests Shuah Khan
2019-09-25 23:04 ` [PATCH 2/2] selftests: Add kselftest_install target to main Makefile Shuah Khan
2019-09-26 3:24 ` Masahiro Yamada
2019-09-26 22:11 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43a7962e-4fae-78e4-1db2-b75c7ff802b1@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=shuah@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).