From: Daniel Borkmann <daniel@iogearbox.net>
To: Simon Horman <simon.horman@netronome.com>,
Anders Roxell <anders.roxell@linaro.org>
Cc: ast@kernel.org, davem@davemloft.net, netdev@vger.kernel.org,
bpf@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, shuah@kernel.org,
songliubraving@fb.com
Subject: Re: [PATCH bpf-next 2/2] selftests: bpf: test_tc_edt: add missing object file to TEST_FILES
Date: Mon, 11 Nov 2019 14:01:00 +0100 [thread overview]
Message-ID: <4ce79d06-e8af-6547-240d-50e3038a6ae7@iogearbox.net> (raw)
In-Reply-To: <20191111124501.alvvekp5owj4daoh@netronome.com>
On 11/11/19 1:45 PM, Simon Horman wrote:
> On Sun, Nov 10, 2019 at 10:26:16AM +0100, Anders Roxell wrote:
>> When installing kselftests to its own directory and running the
>> test_tc_edt.sh it will complain that test_tc_edt.o can't be find.
>>
>> $ ./test_tc_edt.sh
>> Error opening object test_tc_edt.o: No such file or directory
>> Object hashing failed!
>> Cannot initialize ELF context!
>> Unable to load program
>>
>> Rework to add test_tc_edt.o to TEST_FILES so the object file gets
>> installed when installing kselftest.
>>
>> Fixes: 74b5a5968fe8 ("selftests/bpf: Replace test_progs and test_maps w/ general rule")
>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>> Acked-by: Song Liu <songliubraving@fb.com>
>
> It seems to me that the two patches that comprise this series
> should be combined as they seem to be fixing two halves of the same
> problem.
Yep, agree, please respin as single patch.
Thanks,
Daniel
next prev parent reply other threads:[~2019-11-11 13:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-10 9:26 [PATCH bpf-next 1/2] selftests: bpf: test_lwt_ip_encap: add missing object file to TEST_FILES Anders Roxell
2019-11-10 9:26 ` [PATCH bpf-next 2/2] selftests: bpf: test_tc_edt: " Anders Roxell
2019-11-11 12:45 ` Simon Horman
2019-11-11 13:01 ` Daniel Borkmann [this message]
2019-11-11 14:22 ` Anders Roxell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ce79d06-e8af-6547-240d-50e3038a6ae7@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=anders.roxell@linaro.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=simon.horman@netronome.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).