From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD290C56202 for ; Mon, 26 Oct 2020 18:11:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A79F520872 for ; Mon, 26 Oct 2020 18:11:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="c1etfYcK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1789247AbgJZSLl (ORCPT ); Mon, 26 Oct 2020 14:11:41 -0400 Received: from mail-qv1-f65.google.com ([209.85.219.65]:34041 "EHLO mail-qv1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1783537AbgJZSLk (ORCPT ); Mon, 26 Oct 2020 14:11:40 -0400 Received: by mail-qv1-f65.google.com with SMTP id g13so4753130qvu.1 for ; Mon, 26 Oct 2020 11:11:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wXbdbicKVeXDRSO9MY7B1zqIT3oHv+LTHNtkKPt2D2A=; b=c1etfYcK4UNhq0LLeOS3Fyh2e89joQELvnJVPIbaj1PWxbTphDsP0AjrZNeoBzlS5Q 9Vc9V4DtO54YtziHvzgJd/VUGo2LkbvXnN6FWCpvWZCwCL41WH4/MztPmFEl1teTQxqw C4yKXYKJY5GpMxboXZzlnSt/9rCemQusXpalfDg7cf8AGFxMol3mWQgoqmtBi0TLleM8 ge7o+r2S7KDzHYYojoADRVsvln7pDRE2hoW9STGUerFkkVbV7OB4CAO49jRvQU7eCi7c CRQVJmVZHnsTkA3QvN2MiHs2yvLPrafKpvtrKpRUZSx0/q56gFdFIsEuXibDEFD4svFx fkvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wXbdbicKVeXDRSO9MY7B1zqIT3oHv+LTHNtkKPt2D2A=; b=BgDIZOlhImFNiPe2db5jwkTj/ETVJv2+Fxz53rTp9CCfgxGHWXiqjyOnfCk0bdvR8x wu3+hazaYECUQ75YLnfwLGPyQkZ9ggspBeDDXCYNQ3ke7jW7NbfIlu7yVCRPyJ+zPwC8 uKGcluaVlyxwOKpo2vDg1gk7zpTOpEdOJrbQyswtpnixc6T5BRf1WCQHS8bcdMmhXRTv 8/Rk7amZwvvzVUc45V8zoanziJA/Nojl+dxXQYjVypnuuCd/+qv9f7QmYdHHAQqPPrnW IsZn5URJmzfxtWjskn3yvwdALBsbbE9w3q4MIVhAaqBmM8zMJtXNOKiMK4xno0KERCyI Heaw== X-Gm-Message-State: AOAM533OIIeXfGLNadEXQUzDB27LyJLTFWjlTNYOgR3Sc99EU/vw6XiI x9mAscCz83hV7oyE+VqMqBXxH4l6cF529q9GpsFs X-Google-Smtp-Source: ABdhPJxCVt0hlOpjCr4DRBoxaQZuxsKFgDcYuSZvK1o2Qz94wNBVxtgEEFyFN1OHIAFTWCkpOw8UBiG+JoZum53bHpE= X-Received: by 2002:ad4:46a8:: with SMTP id br8mr18327630qvb.24.1603735899186; Mon, 26 Oct 2020 11:11:39 -0700 (PDT) MIME-Version: 1.0 References: <20201023150536.282568-1-98.arpi@gmail.com> <20201023150634.282631-1-98.arpi@gmail.com> In-Reply-To: <20201023150634.282631-1-98.arpi@gmail.com> From: Iurii Zaikin Date: Mon, 26 Oct 2020 11:11:02 -0700 Message-ID: Subject: Re: [PATCH v2 2/2] fs: ext4: Modify inode-test.c to use KUnit parameterized testing feature To: Arpitha Raghunandan <98.arpi@gmail.com> Cc: Brendan Higgins , Shuah Khan , Marco Elver , "Theodore Ts'o" , Andreas Dilger , "open list:KERNEL SELFTEST FRAMEWORK" , KUnit Development , Linux Kernel Mailing List , linux-kernel-mentees@lists.linuxfoundation.org, Ext4 Developers List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org > +static struct timestamp_expectation test_data[] = { Can you mark this and the rest of the hardcoded values as the const they are?