From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D488CA9EC8 for ; Fri, 18 Oct 2019 00:34:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0785821D80 for ; Fri, 18 Oct 2019 00:34:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="OXsvF7SQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393047AbfJRAee (ORCPT ); Thu, 17 Oct 2019 20:34:34 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:46625 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728419AbfJRAee (ORCPT ); Thu, 17 Oct 2019 20:34:34 -0400 Received: by mail-qt1-f194.google.com with SMTP id u22so6487135qtq.13 for ; Thu, 17 Oct 2019 17:34:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EUlu1SWs2RKAwKCxV/9R7y8e+BDWGAAyqQ0an1Lsr9Q=; b=OXsvF7SQN+XYVlWUa+QkhyzQlY82oddbjvaFWnStUlidnn51dbg5obEKiaFj5zoc6y vwi5qirf6p/I0EprCYIHbJ5s7+dKa9zNJS8Qct/sXCBLvXojZX4N73eeclUdVuTxr2on fZXxUG70SWof9y9B7g5dOIsLuBZ7XoEFF9ecWJvzkLQKUHpTID6x+qqIrr18yBuXY8dt zYEoKT5bh90GuwYNAIGH9pzHKtKGDQmuA/V53vp9QsYW8ruCmJvctmoiowhBgqny1/H5 hYvFurEpJdqTOzUYmmTUEqt0V85cGgxkNayG1xlayYRjioTgROxq8AM9L70jMK/3QGEx O06w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EUlu1SWs2RKAwKCxV/9R7y8e+BDWGAAyqQ0an1Lsr9Q=; b=V0m/X+LnrWquWUyC/UUiLembwaRCqSUtBIhJt8H63iik/nPeD3GR8sRY6Z9XxJuEdU GT1f00OI/o86b/PbGFekLn6r7HKUoh6SomZw65TyE8Z6qQ+E3YDOjIuTY6LTaeqi5emX wPgIz0ps4mSoTcgilOoyntnL4rDTbrSNCpw4LjriOdtyPPRwxXNnETdVCbJ6PO/0xSYF dE/p3H5c97prSl+CIOAhXtmrdwNYvs5HTuQd7IHhoQ3oAtC9C7mVn5/ZVya8gvD/9IXu 2Nmsk6j5jCaz/vv4YFoGZe7K9RaIcvtc1UAEuJHygNAjUjA1IAv0Tz56jBasHhD54akn cgnQ== X-Gm-Message-State: APjAAAVrzKFvGVFhqqvxJ0cW2cH/beqXBVg8DyS3MD4PTY4GKMKbRD4y PJo+S3XZM6lJN0GYeza9Qp2sW5dz0GPY/7X/+mfq X-Google-Smtp-Source: APXvYqysQ8azqkhvfL+IXNSJUTjI5cgJ7rhGxwOr2jR4+xdknSlXEXLf5ULzXQL+NHfP+CJNDsIennPxYQdpYJ61h60= X-Received: by 2002:ac8:5147:: with SMTP id h7mr6962616qtn.160.1571358872431; Thu, 17 Oct 2019 17:34:32 -0700 (PDT) MIME-Version: 1.0 References: <20191018001816.94460-1-brendanhiggins@google.com> In-Reply-To: <20191018001816.94460-1-brendanhiggins@google.com> From: Iurii Zaikin Date: Thu, 17 Oct 2019 17:33:56 -0700 Message-ID: Subject: Re: [PATCH linux-kselftest/test v1] apparmor: add AppArmor KUnit tests for policy unpack To: Brendan Higgins Cc: shuah , john.johansen@canonical.com, jmorris@namei.org, serge@hallyn.com, keescook@chromium.org, alan.maguire@oracle.com, davidgow@google.com, Luis Chamberlain , "Theodore Ts'o" , Linux Kernel Mailing List , linux-security-module@vger.kernel.org, KUnit Development , "open list:KERNEL SELFTEST FRAMEWORK" , Mike Salvatore Content-Type: text/plain; charset="UTF-8" Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Thu, Oct 17, 2019 at 5:19 PM Brendan Higgins wrote: > +config SECURITY_APPARMOR_TEST > + bool "Build KUnit tests for policy_unpack.c" > + default n > + depends on KUNIT && SECURITY_APPARMOR > + help > select SECURITY_APPARMOR ? > + KUNIT_EXPECT_EQ(test, size, TEST_BLOB_DATA_SIZE); > + KUNIT_EXPECT_TRUE(test, > + memcmp(blob, TEST_BLOB_DATA, TEST_BLOB_DATA_SIZE) == 0); I think this must be KUNIT_ASSERT_EQ(test, size, TEST_BLOB_DATA_SIZE);, otherwise there could be a buffer overflow in memcmp. All tests that follow such pattern are suspect. Also, not sure about your stylistic preference for KUNIT_EXPECT_TRUE(test, memcmp(blob, TEST_BLOB_DATA, TEST_BLOB_DATA_SIZE) == 0); vs KUNIT_EXPECT_EQ(test, 0, memcmp(blob, TEST_BLOB_DATA, TEST_BLOB_DATA_SIZE));