From: Vitor Massaru Iha <vitor@massaru.org>
To: peterz@infradead.org
Cc: KUnit Development <kunit-dev@googlegroups.com>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Brendan Higgins <brendanhiggins@google.com>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
Ian Rogers <irogers@google.com>,
mingo@kernel.org
Subject: Re: [PATCH] lib: kunit: add test_min_heap test conversion to KUnit
Date: Tue, 4 Aug 2020 13:22:03 -0300 [thread overview]
Message-ID: <CADQ6JjWbCsyWxZKQ5=kkxx8hkaW=mbCjDodPXDAv5vH-=tVvEQ@mail.gmail.com> (raw)
In-Reply-To: <20200804142344.GM2674@hirez.programming.kicks-ass.net>
Hi Peter,
On Tue, Aug 4, 2020 at 11:23 AM <peterz@infradead.org> wrote:
>
> On Tue, Aug 04, 2020 at 10:46:21AM -0300, Vitor Massaru Iha wrote:
> > On Tue, Aug 4, 2020 at 10:25 AM <peterz@infradead.org> wrote:
> > > On Wed, Jul 29, 2020 at 06:57:17PM -0300, Vitor Massaru Iha wrote:
> > >
> > > > The results can be seen this way:
> > > >
> > > > This is an excerpt from the test.log with the result in TAP format:
> > > > [snip]
> > > > ok 5 - example
> > > > # Subtest: min-heap
> > > > 1..6
> > > > ok 1 - test_heapify_all_true
> > > > ok 2 - test_heapify_all_false
> > > > ok 3 - test_heap_push_true
> > > > ok 4 - test_heap_push_false
> > > > ok 5 - test_heap_pop_push_true
> > > > ok 6 - test_heap_pop_push_false
> > > > [snip]
>
> So ^ is TAP format?
Yep, you can see the spec here: https://testanything.org/tap-specification.html
>
> > > I don't care or care to use either; what does dmesg do? It used to be
> > > that just building the self-tests was sufficient and any error would
> > > show in dmesg when you boot the machine.
> > >
> > > But if I now have to use some damn tool, this is a regression.
> >
> > If you don't want to, you don't need to use the kunit-tool. If you
> > compile the tests as builtin and run the Kernel on your machine
> > the test result will be shown in dmesg in TAP format.
>
> That's seems a lot more verbose than it is now. I've recently even done
> a bunch of tests that don't print anything on success, dmesg is clutter
> enough already.
What tests do you refer to?
Running the test_min_heap.c, I got this from dmesg:
min_heap_test: test passed
And running min_heap_kunit.c:
ok 1 - min-heap
BR,
Vitor
next prev parent reply other threads:[~2020-08-04 16:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 20:11 [PATCH] lib: kunit: add test_min_heap test conversion to KUnit Vitor Massaru Iha
2020-07-29 20:39 ` peterz
2020-07-29 21:57 ` Vitor Massaru Iha
2020-08-04 13:25 ` peterz
2020-08-04 13:46 ` Vitor Massaru Iha
2020-08-04 14:23 ` peterz
2020-08-04 16:22 ` Vitor Massaru Iha [this message]
2020-10-12 21:02 ` Brendan Higgins
2020-10-14 18:16 ` Ian Rogers
2020-10-14 19:59 ` Peter Zijlstra
2020-10-14 20:03 ` Vitor Massaru Iha
2020-07-29 22:56 ` Ian Rogers
2020-07-29 23:12 ` Vitor Massaru Iha
2020-10-14 23:49 ` Vitor Massaru Iha
2020-10-15 16:30 ` Ian Rogers
2020-10-15 16:56 ` Vitor Massaru Iha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADQ6JjWbCsyWxZKQ5=kkxx8hkaW=mbCjDodPXDAv5vH-=tVvEQ@mail.gmail.com' \
--to=vitor@massaru.org \
--cc=brendanhiggins@google.com \
--cc=irogers@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).