From: Brendan Higgins <brendanhiggins@google.com>
To: Sadiya Kazi <sadiyakazi@google.com>
Cc: davidgow@google.com, skhan@linuxfoundation.org, corbet@lwn.net,
mairacanal@riseup.net, linux-kselftest@vger.kernel.org,
kunit-dev@googlegroups.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Documentation: kunit: Add CLI args for kunit_tool
Date: Thu, 21 Jul 2022 20:27:35 -0400 [thread overview]
Message-ID: <CAFd5g47jfm8dZ=3jwdy2Vhy+PgAW8JLAPmikhAUVTc-udKZjNA@mail.gmail.com> (raw)
In-Reply-To: <20220721081026.1247067-1-sadiyakazi@google.com>
On Thu, Jul 21, 2022 at 4:26 AM Sadiya Kazi <sadiyakazi@google.com> wrote:
>
> Run_wrapper.rst was missing some command line arguments. Added
> additional args in the file.
>
> Signed-off-by: Sadiya Kazi <sadiyakazi@google.com>
Aside from the small nits pointed out by Maíra and David, this looks good to me.
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
next prev parent reply other threads:[~2022-07-22 0:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 8:10 [PATCH v2] Documentation: kunit: Add CLI args for kunit_tool Sadiya Kazi
2022-07-21 11:08 ` Maíra Canal
2022-07-21 23:54 ` David Gow
2022-07-22 0:24 ` Brendan Higgins
2022-07-22 0:27 ` Brendan Higgins [this message]
2022-07-22 0:54 ` Daniel Latypov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFd5g47jfm8dZ=3jwdy2Vhy+PgAW8JLAPmikhAUVTc-udKZjNA@mail.gmail.com' \
--to=brendanhiggins@google.com \
--cc=corbet@lwn.net \
--cc=davidgow@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mairacanal@riseup.net \
--cc=sadiyakazi@google.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).