From: Daniel Latypov <dlatypov@google.com>
To: "Maíra Canal" <mairacanal@riseup.net>
Cc: Brendan Higgins <brendanhiggins@google.com>,
davidgow@google.com, airlied@linux.ie, daniel@ffwll.ch,
davem@davemloft.net, kuba@kernel.org, jose.exposito89@gmail.com,
javierm@redhat.com, andrealmeid@riseup.net,
melissa.srw@gmail.com, siqueirajordao@riseup.net,
Isabella Basso <isabbasso@riseup.net>,
magalilemes00@gmail.com, tales.aparecida@gmail.com,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] kunit: Add KUnit memory block assertions to the example_all_expect_macros_test
Date: Tue, 2 Aug 2022 14:57:39 -0700 [thread overview]
Message-ID: <CAGS_qxqBCjcX1iL9D_1pCM47pN+OwRG7=Pfd2DWyzwFNFJhkgg@mail.gmail.com> (raw)
In-Reply-To: <20220802212621.420840-3-mairacanal@riseup.net>
On Tue, Aug 2, 2022 at 2:26 PM Maíra Canal <mairacanal@riseup.net> wrote:
>
> Increament the example_all_expect_macros_test with the
nit: typo ("Increment")
But "Augment" would be a bit more idiomatic here
Sorry I didn't catch this one in v1.
> KUNIT_EXPECT_MEMEQ and KUNIT_EXPECT_MEMNEQ macros by creating a test
> with memory block assertions.
>
> Signed-off-by: Maíra Canal <mairacanal@riseup.net>
Reviewed-by: Daniel Latypov <dlatypov@google.com>
Thanks!
Just a couple very small nits (one above, one below).
> ---
> - Change the macro KUNIT_EXPECT_ARREQ to KUNIT_EXPECT_MEMEQ, in order to make
> it easier for users to infer the right size unit (Daniel Latypov).
> - Replace a constant number of array elements for ARRAY_SIZE() (André Almeida).
> - Rename "array" and "expected" variables to "array1" and "array2" (Daniel Latypov).
> ---
> lib/kunit/kunit-example-test.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/lib/kunit/kunit-example-test.c b/lib/kunit/kunit-example-test.c
> index f8fe582c9e36..8a9b0eeb1934 100644
> --- a/lib/kunit/kunit-example-test.c
> +++ b/lib/kunit/kunit-example-test.c
> @@ -86,6 +86,9 @@ static void example_mark_skipped_test(struct kunit *test)
> */
> static void example_all_expect_macros_test(struct kunit *test)
> {
> + const u32 array1[] = { 0x0F, 0xFF };
> + const u32 array2[] = { 0x1F, 0xFF };
> +
> /* Boolean assertions */
> KUNIT_EXPECT_TRUE(test, true);
> KUNIT_EXPECT_FALSE(test, false);
> @@ -109,6 +112,10 @@ static void example_all_expect_macros_test(struct kunit *test)
> KUNIT_EXPECT_STREQ(test, "hi", "hi");
> KUNIT_EXPECT_STRNEQ(test, "hi", "bye");
>
> + /* Memory block assertions */
> + KUNIT_EXPECT_MEMEQ(test, array1, array1, sizeof(u32) * ARRAY_SIZE(array1));
> + KUNIT_EXPECT_MEMNEQ(test, array1, array2, sizeof(u32) * ARRAY_SIZE(array1));
Note: the following would be equivalent
KUNIT_EXPECT_MEMEQ(test, array1, array1, sizeof(array1));
KUNIT_EXPECT_MEMNEQ(test, array1, array2, sizeof(array1));
I think now we've dropped the use of "array equal", sizeof() is also
generally more appropriate.
We could also optionally prefix these with
KUNIT_ASSERT_EQ(test, sizeof(array1), sizeof(array2));
if we want to be extra paranoid here, but I don't think that's really necessary.
next prev parent reply other threads:[~2022-08-02 21:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 21:26 [PATCH v2 0/3] Introduce KUNIT_EXPECT_MEMEQ and KUNIT_EXPECT_MEMNEQ macros Maíra Canal
2022-08-02 21:26 ` [PATCH v2 1/3] kunit: " Maíra Canal
2022-08-02 22:24 ` Daniel Latypov
2022-08-02 21:26 ` [PATCH v2 2/3] kunit: Add KUnit memory block assertions to the example_all_expect_macros_test Maíra Canal
2022-08-02 21:57 ` Daniel Latypov [this message]
2022-08-02 21:26 ` [PATCH v2 3/3] kunit: Use KUNIT_EXPECT_MEMEQ macro Maíra Canal
2022-08-02 22:29 ` Daniel Latypov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGS_qxqBCjcX1iL9D_1pCM47pN+OwRG7=Pfd2DWyzwFNFJhkgg@mail.gmail.com' \
--to=dlatypov@google.com \
--cc=airlied@linux.ie \
--cc=andrealmeid@riseup.net \
--cc=brendanhiggins@google.com \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=davidgow@google.com \
--cc=isabbasso@riseup.net \
--cc=javierm@redhat.com \
--cc=jose.exposito89@gmail.com \
--cc=kuba@kernel.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=magalilemes00@gmail.com \
--cc=mairacanal@riseup.net \
--cc=melissa.srw@gmail.com \
--cc=siqueirajordao@riseup.net \
--cc=tales.aparecida@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).