From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C5C5C433EF for ; Thu, 23 Jun 2022 12:24:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230250AbiFWMYg (ORCPT ); Thu, 23 Jun 2022 08:24:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231335AbiFWMYf (ORCPT ); Thu, 23 Jun 2022 08:24:35 -0400 Received: from mail-oa1-x30.google.com (mail-oa1-x30.google.com [IPv6:2001:4860:4864:20::30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F8B03207A for ; Thu, 23 Jun 2022 05:24:34 -0700 (PDT) Received: by mail-oa1-x30.google.com with SMTP id 586e51a60fabf-1013ecaf7e0so26357944fac.13 for ; Thu, 23 Jun 2022 05:24:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qcOFv+gUkOUIJJ72OOZ9NseYxv0LoGb9wAQ/jFJ2Dk8=; b=ZGAwRzzE8VL85qRDYfMIvCrIHJkVRiIYei98dO36+lgVyF3FWJUe7hqqUrsTwy639Y fc+W8/1hfo7JZohSBn0BmrXgCAuBJ5vCaJB2sAWPRSGsx6O74BR4aBhFhTsdrI8SVpw6 yHYggGBjd/sq0CYiDjkFfZkeqRUmrn4J7Dg4e7iicPa2yWiHeuY+8e+bLsDAiI4i8pyr EV80OclS5ilc1yqKp6AG1B401ALvhV3exYBeb2IeV0OW8rpAFVov8Ge0ATahc3RcmxRF 4FFQUAnzOwhEN6/m8cyLiVsmXun+S618Er5jfz5mSVTteervSKejh8lx4MtRyhHmQCtR ZssA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qcOFv+gUkOUIJJ72OOZ9NseYxv0LoGb9wAQ/jFJ2Dk8=; b=ZLAdp5dmASIcC4iDrzCCFxHXNE9QbyY5c4KBKW1pOc2A6bKAICFMeCOrBvvNvTFlLm 43DXvXePpGnC6GOzSo6lWQars1MjsTJ/JQnyQtAF96XltLrvRNgiMCAC1VaDNW4MFY9A jm6vHqpN6qe8eNAn7mSC9f90wyjRphjlehI7ZXMU4ZZD5PCIlFfVK1zAXuOMCOOwpD4i G0FsRPPB11cGa79BsrYFXmDkVQppRrG3oy5XSuEhRAglMnRhc55wmu70Mt0R8WyXle65 p5XNhilUF3Svory5Rkgon3I/MoIzam3BOl7ven8gacn8GeN2gcsuqfYiBZofIicF1wDs 86aA== X-Gm-Message-State: AJIora+CAgT5CsCYVzgXJwKbNxP6KrFdmA9a4kRn02ctOL/eHEnacqMw EOotJDLGNH/DfWgzF8QD0WkGbCadIcZPS2FDU04d+zKsTpQ= X-Google-Smtp-Source: AGRyM1tolYit2qOF13LQll2M1apYzVAPtBssHfNXvX79yFs+qX/QdnWSuZSn9LvvuTfowIJzogE5Gto6i2wMUvkyN5I= X-Received: by 2002:a05:6870:33a9:b0:f2:c44c:d054 with SMTP id w41-20020a05687033a900b000f2c44cd054mr2317236oae.70.1655987073368; Thu, 23 Jun 2022 05:24:33 -0700 (PDT) MIME-Version: 1.0 References: <20220621085345.603820-1-davidgow@google.com> <20220621085345.603820-6-davidgow@google.com> In-Reply-To: From: Ulf Hansson Date: Thu, 23 Jun 2022 14:23:57 +0200 Message-ID: Subject: Re: [PATCH v2 5/5] mmc: sdhci-of-aspeed: test: Use kunit_test_suite() macro To: David Gow , Daniel Latypov Cc: Brendan Higgins , Luis Chamberlain , Jeremy Kerr , Shuah Khan , Andrew Jeffery , Mika Westerberg , Andra Paraschiv , Longpeng , Paraschiv@google.com, Christophe Leroy , kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?B?TWHDrXJhIENhbmFs?= , linux-mmc@vger.kernel.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-usb@vger.kernel.org, linux-modules@vger.kernel.org, Matt Johnston Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Wed, 22 Jun 2022 at 00:19, Daniel Latypov wrote: > > On Tue, Jun 21, 2022 at 1:54 AM David Gow wrote: > > > > The kunit_test_suite() macro is no-longer incompatible with module_add, > > so its use can be reinstated. > > > > Since this fixes parsing with builtins and kunit_tool, also enable the > > test by default when KUNIT_ALL_TESTS is enabled. > > > > The test can now be run via kunit_tool with: > > ./tools/testing/kunit/kunit.py run --arch=x86_64 \ > > --kconfig_add CONFIG_OF=y --kconfig_add CONFIG_OF_ADDRESS=y \ > > --kconfig_add CONFIG_MMC=y --kconfig_add CONFIG_MMC_SDHCI=y \ > > --kconfig_add CONFIG_MMC_SDHCI_PLTFM=y \ > > --kconfig_add CONFIG_MMC_SDHCI_OF_ASPEED=y \ > > 'sdhci-of-aspeed' > > > > (It may be worth adding a .kunitconfig at some point, as there are > > enough dependencies to make that command scarily long.) > > > > Signed-off-by: David Gow > > Acked-by: Daniel Latypov > > Minor, optional suggestion below. > > > static int __init aspeed_sdc_init(void) > > @@ -639,12 +620,6 @@ static int __init aspeed_sdc_init(void) > > if (rc < 0) > > goto cleanup_sdhci; > > > > - rc = aspeed_sdc_tests_init(); > > - if (rc < 0) { > > - platform_driver_unregister(&aspeed_sdc_driver); > > - goto cleanup_sdhci; > > - } > > - > > return 0; > > > > cleanup_sdhci: > > This goto was added in 4af307f57426 ("mmc: sdhci-of-aspeed: Fix > kunit-related build error") to allow for this extra call to > aspeed_sdc_tests_init(). > > This could now be reverted back to what is > rc = platform_driver_register(&aspeed_sdc_driver); > if (rc < 0) > platform_driver_unregister(&aspeed_sdhci_driver); > > return rc; > > but let's see what the maintainers think. I don't have a strong opinion on this, feel free to pick any of the options. Acked-by: Ulf Hansson Kind regards Uffe