From: <Tim.Bird@sony.com>
To: <cristian.marussi@arm.com>, <linux-kselftest@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <shuah@kernel.org>
Cc: <dave.martin@arm.com>
Subject: RE: [PATCH 1/2] kselftest: add capability to skip chosen TARGETS
Date: Wed, 25 Sep 2019 20:20:07 +0000 [thread overview]
Message-ID: <ECADFF3FD767C149AD96A924E7EA6EAF977BD152@USCULXMSG01.am.sony.com> (raw)
In-Reply-To: <20190925132421.23572-1-cristian.marussi@arm.com>
Just a few nits inline below.
> -----Original Message-----
> From: Cristian Marussi on Wednesday, September 25, 2019 3:24 AM
>
> Let the user specify an optional TARGETS skiplist through the new optional
> SKIP_TARGETS Makefile variable.
>
> It is easier to skip at will a reduced and well defined list of possibly
It seems like there's a word missing.
at will a -> at will using a
> problematic targets with SKIP_TARGETS then to provide a partially stripped
then -> than
> down list of good targets using the usual TARGETS variable.
>
> Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
> ---
> tools/testing/selftests/Makefile | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/testing/selftests/Makefile
> b/tools/testing/selftests/Makefile
> index 25b43a8c2b15..103936faa46d 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -132,6 +132,10 @@ else
> ARCH=$(ARCH) -C $(top_srcdir) headers_install
> endif
>
> +# User can optionally provide a TARGETS skiplist.
> +SKIP_TARGETS ?=
> +TARGETS := $(filter-out $(SKIP_TARGETS), $(TARGETS))
> +
> all: khdr
> @for TARGET in $(TARGETS); do \
> BUILD_TARGET=$$BUILD/$$TARGET; \
> --
> 2.17.1
Great feature! Thanks.
-- Tim
next prev parent reply other threads:[~2019-09-25 20:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 13:24 [PATCH 1/2] kselftest: add capability to skip chosen TARGETS Cristian Marussi
2019-09-25 13:24 ` [PATCH 2/2] kselftest: exclude failed TARGETS from runlist Cristian Marussi
2019-09-25 19:36 ` shuah
2019-09-25 19:36 ` [PATCH 1/2] kselftest: add capability to skip chosen TARGETS shuah
2019-09-26 9:24 ` Cristian Marussi
2019-09-25 20:20 ` Tim.Bird [this message]
2019-09-26 9:26 ` Cristian Marussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ECADFF3FD767C149AD96A924E7EA6EAF977BD152@USCULXMSG01.am.sony.com \
--to=tim.bird@sony.com \
--cc=cristian.marussi@arm.com \
--cc=dave.martin@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).