From: Pengfei Xu <pengfei.xu@intel.com>
To: "Kuppuswamy, Sathyanarayanan" <sathyanarayanan.kuppuswamy@intel.com>
Cc: Shuah Khan <skhan@linuxfoundation.org>, <shuah@kernel.org>,
linux-kselftest <linux-kselftest@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
<jithu.joseph@intel.com>, <ashok.raj@intel.com>
Subject: Re: [PATCH v1 0/4] add tests to verify IFS (In Field Scan) driver functionality
Date: Wed, 15 May 2024 13:15:56 +0800 [thread overview]
Message-ID: <ZkRFDEgjOg0whpVa@xpf.sh.intel.com> (raw)
In-Reply-To: <d3e4761e-a44a-400e-9aea-df5322169c87@intel.com>
On 2024-05-14 at 20:55:11 -0700, Kuppuswamy, Sathyanarayanan wrote:
>
> On 4/29/24 8:31 PM, Pengfei Xu wrote:
> > To verify IFS (In Field Scan [1]) driver functionality, add the following 6
> > test cases:
> > 1. Verify that IFS sysfs entries are created after loading the IFS module
> > 2. Check if loading an invalid IFS test image fails and loading a valid
> > one succeeds
> > 3. Perform IFS scan test on each CPU using all the available image files
> > 4. Perform IFS scan with first test image file on a random CPU for 3
> > rounds
> > 5. Perform IFS ARRAY BIST(Board Integrated System Test) test on each CPU
> > 6. Perform IFS ARRAY BIST test on a random CPU for 3 rounds
> >
> > These are not exhaustive, but some minimal test runs to check various
> > parts of the driver. Some negative tests are also included.
> >
> > [1] https://docs.kernel.org/arch/x86/ifs.html
>
> Looks good to me.
>
> Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Thanks for Sathya's tag, and thanks Shuah and Jithu also.
Best Regards,
Thanks!
>
> > Pengfei Xu (4):
> > selftests: ifs: verify test interfaces are created by the driver
> > selftests: ifs: verify test image loading functionality
> > selftests: ifs: verify IFS scan test functionality
> > selftests: ifs: verify IFS ARRAY BIST functionality
> >
> > MAINTAINERS | 1 +
> > tools/testing/selftests/Makefile | 1 +
> > .../drivers/platform/x86/intel/ifs/Makefile | 6 +
> > .../platform/x86/intel/ifs/test_ifs.sh | 496 ++++++++++++++++++
> > 4 files changed, 504 insertions(+)
> > create mode 100644 tools/testing/selftests/drivers/platform/x86/intel/ifs/Makefile
> > create mode 100755 tools/testing/selftests/drivers/platform/x86/intel/ifs/test_ifs.sh
> >
> --
> Sathyanarayanan Kuppuswamy
> Linux Kernel Developer
>
prev parent reply other threads:[~2024-05-15 5:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 3:31 [PATCH v1 0/4] add tests to verify IFS (In Field Scan) driver functionality Pengfei Xu
2024-04-30 3:31 ` [PATCH v1 1/4] selftests: ifs: verify test interfaces are created by the driver Pengfei Xu
2024-04-30 3:31 ` [PATCH v1 2/4] selftests: ifs: verify test image loading functionality Pengfei Xu
2024-04-30 3:31 ` [PATCH v1 3/4] selftests: ifs: verify IFS scan test functionality Pengfei Xu
2024-04-30 3:31 ` [PATCH v1 4/4] selftests: ifs: verify IFS ARRAY BIST functionality Pengfei Xu
2024-05-14 16:45 ` [PATCH v1 0/4] add tests to verify IFS (In Field Scan) driver functionality Shuah Khan
2024-05-14 17:39 ` Joseph, Jithu
2024-05-15 3:55 ` Kuppuswamy, Sathyanarayanan
2024-05-15 5:15 ` Pengfei Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkRFDEgjOg0whpVa@xpf.sh.intel.com \
--to=pengfei.xu@intel.com \
--cc=ashok.raj@intel.com \
--cc=jithu.joseph@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@intel.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).