From: Alan Maguire <alan.maguire@oracle.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Alan Maguire <alan.maguire@oracle.com>,
brendanhiggins@google.com, gregkh@linuxfoundation.org,
rjw@rjwysocki.net, dmitry.torokhov@gmail.com,
sfr@canb.auug.org.au, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org, linux-kselftest@vger.kernel.org,
skhan@linuxfoundation.org
Subject: Re: [PATCH] software node: introduce CONFIG_KUNIT_DRIVER_PE_TEST
Date: Tue, 14 Jan 2020 16:42:37 +0000 (GMT) [thread overview]
Message-ID: <alpine.LRH.2.20.2001141639240.15464@dhcp-10-175-171-251.vpn.oracle.com> (raw)
In-Reply-To: <2242e184-93a5-147d-d603-4017ca86eba9@infradead.org>
On Tue, 14 Jan 2020, Randy Dunlap wrote:
> Hi Alan,
>
> On 1/14/20 8:09 AM, Alan Maguire wrote:
> > currently the property entry kunit tests are built if CONFIG_KUNIT=y.
> > This will cause warnings when merged with the kunit tree that now
> > supports tristate CONFIG_KUNIT. While the tests appear to compile
> > as a module, we get a warning about missing module license.
> >
> > It's better to have a per-test suite CONFIG variable so that
> > we can do selective building of kunit-based suites, and can
> > also avoid merge issues like this.
> >
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
>
Apologies for missing you out here.
> > Fixes: c032ace71c29 ("software node: add basic tests for property entries")
> > Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
> > ---
> > drivers/base/test/Kconfig | 3 +++
> > drivers/base/test/Makefile | 2 +-
> > 2 files changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/base/test/Kconfig b/drivers/base/test/Kconfig
> > index 86e85da..d29ae95 100644
> > --- a/drivers/base/test/Kconfig
> > +++ b/drivers/base/test/Kconfig
> > @@ -8,3 +8,6 @@ config TEST_ASYNC_DRIVER_PROBE
> > The module name will be test_async_driver_probe.ko
> >
> > If unsure say N.
> > +config KUNIT_DRIVER_PE_TEST
> > + bool "KUnit Tests for property entry API"
> > + depends on KUNIT
>
> Why is this bool instead of tristate?
>
The support for building kunit and kunit tests as modules has not merged
into linux-next yet, so if we set the option to tristate the build would
fail for allmodconfig builds. Once it's merged we can revisit though; I
should have mentioned this, thanks for reminding me!
Alan
> > diff --git a/drivers/base/test/Makefile b/drivers/base/test/Makefile
> > index 2214310..3ca5636 100644
> > --- a/drivers/base/test/Makefile
> > +++ b/drivers/base/test/Makefile
> > @@ -1,4 +1,4 @@
> > # SPDX-License-Identifier: GPL-2.0
> > obj-$(CONFIG_TEST_ASYNC_DRIVER_PROBE) += test_async_driver_probe.o
> >
> > -obj-$(CONFIG_KUNIT) += property-entry-test.o
> > +obj-$(CONFIG_KUNIT_DRIVER_PE_TEST) += property-entry-test.o
> >
>
> thanks.
> --
> ~Randy
>
>
next prev parent reply other threads:[~2020-01-14 16:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 16:09 [PATCH] software node: introduce CONFIG_KUNIT_DRIVER_PE_TEST Alan Maguire
2020-01-14 16:30 ` Randy Dunlap
2020-01-14 16:42 ` Alan Maguire [this message]
2020-01-14 16:45 ` Randy Dunlap
2020-01-14 22:43 ` Rafael J. Wysocki
2020-01-14 23:52 ` Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.20.2001141639240.15464@dhcp-10-175-171-251.vpn.oracle.com \
--to=alan.maguire@oracle.com \
--cc=brendanhiggins@google.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=sfr@canb.auug.org.au \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).