From: Shuah Khan <skhan@linuxfoundation.org>
To: Fenghua Yu <fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>,
Reinette Chatre <reinette.chatre@intel.com>,
Tony Luck <tony.luck@intel.com>, Babu Moger <babu.moger@amd.com>,
James Morse <james.morse@arm.com>, Borislav Petkov <bp@alien8.de>,
Thomas Gleixner <tglx@linutronix.de>,
Ravi V Shankar <ravi.v.shankar@intel.com>
Cc: linux-kselftest <linux-kselftest@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v3 00/21] Miscellaneous fixes for resctrl selftests
Date: Tue, 27 Oct 2020 18:46:27 -0600 [thread overview]
Message-ID: <c4fe6c5a-e5c4-0653-9e35-ab03f5494744@linuxfoundation.org> (raw)
In-Reply-To: <20201020235126.1871815-1-fenghua.yu@intel.com>
On 10/20/20 5:51 PM, Fenghua Yu wrote:
> This patch set has several miscellaneous fixes to resctrl selftest tool
> that are easily visible to user. V1 had fixes to CAT test and CMT test
> but they were dropped in V2 because having them here made the patchset
> humongous. So, changes to CAT test and CMT test will be posted in another
> patchset.
>
This is still a very long patch series. Several of the patches can be
combined and can be rearranged. 21 patches don't seem to any specific
order.
> Change Log:
> v3:
> Address various comments (commit messages, return value on test failure,
> print failure info on test failure etc) from Reinette and Tony.
> [v2: https://lore.kernel.org/linux-kselftest/cover.1589835155.git.sai.praneeth.prakhya@intel.com/]
>
> v2:
> 1. Dropped changes to CAT test and CMT test as they will be posted in a later
> series.
> 2. Added several other fixes
> [v1: https://lore.kernel.org/linux-kselftest/cover.1583657204.git.sai.praneeth.prakhya@intel.com/]
>
> Fenghua Yu (18):
> selftests/resctrl: Rename CQM test as CMT test
> selftests/resctrl: Declare global variables as extern
> selftests/resctrl: Return if resctrl file system is not supported
> selftests/resctrl: Check for resctrl mount point only if resctrl FS is
> supported
> selftests/resctrl: Use resctrl/info for feature detection
> selftests/resctrl: Fix missing options "-n" and "-p"
> selftests/resctrl: Fix MBA/MBM results reporting format
> selftests/resctrl: Abort running tests if not root user
> selftests/resctrl: Enable gcc checks to detect buffer overflows
> selftests/resctrl: Don't hard code value of "no_of_bits" variable
> selftests/resctrl: Modularize resctrl test suite main() function
Yes. This is a needed change. I didn't make it to this patch yet.
> selftests/resctrl: Skip the test if requested resctrl feature is not
> supported
Commented on this patch already. Look into using config file like other
tests.
> selftests/resctrl: Umount resctrl FS only if mounted
> selftests/resctrl: Unmount resctrl FS after running all tests
> selftests/resctrl: Fix incorrect parsing of iMC counters
> selftests/resctrl: Fix checking for < 0 for unsigned values
> selftests/resctrl: Fix unnecessary usage of global variables
> selftests/resctrl: Don't use global variable for capacity bitmask
> (CBM)
>
> Reinette Chatre (3):
> selftests/resctrl: Fix typo
> selftests/resctrl: Fix typo in help text
Why not combine the above two patches. The commit summary doesn't
make sense.
> selftests/resctrl: Ensure sibling CPU is not same as original CPU
>
> tools/testing/selftests/resctrl/Makefile | 2 +-
> tools/testing/selftests/resctrl/README | 4 +-
> tools/testing/selftests/resctrl/cache.c | 4 +-
> tools/testing/selftests/resctrl/cat_test.c | 20 +--
> .../resctrl/{cqm_test.c => cmt_test.c} | 34 ++--
> tools/testing/selftests/resctrl/mba_test.c | 23 ++-
> tools/testing/selftests/resctrl/mbm_test.c | 16 +-
> tools/testing/selftests/resctrl/resctrl.h | 20 ++-
> .../testing/selftests/resctrl/resctrl_tests.c | 156 ++++++++++++------
> tools/testing/selftests/resctrl/resctrl_val.c | 75 ++++++---
> tools/testing/selftests/resctrl/resctrlfs.c | 79 ++++++---
> 11 files changed, 272 insertions(+), 161 deletions(-)
> rename tools/testing/selftests/resctrl/{cqm_test.c => cmt_test.c} (85%)
>
I will review rest of the patches. Try to combine a few patches and
collapse fixes. I would like to see all the fixes first and then
renaming from CQM to CMT.
thanks,
-- Shuah
prev parent reply other threads:[~2020-10-29 0:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 23:51 [PATCH v3 00/21] Miscellaneous fixes for resctrl selftests Fenghua Yu
2020-10-20 23:51 ` [PATCH v3 01/21] selftests/resctrl: Rename CQM test as CMT test Fenghua Yu
2020-10-27 20:55 ` Shuah Khan
2020-10-20 23:51 ` [PATCH v3 02/21] selftests/resctrl: Fix typo Fenghua Yu
2020-10-27 20:56 ` Shuah Khan
2020-10-20 23:51 ` [PATCH v3 03/21] selftests/resctrl: Fix typo in help text Fenghua Yu
2020-10-27 20:58 ` Shuah Khan
2020-10-20 23:51 ` [PATCH v3 04/21] selftests/resctrl: Declare global variables as extern Fenghua Yu
2020-10-20 23:51 ` [PATCH v3 05/21] selftests/resctrl: Return if resctrl file system is not supported Fenghua Yu
2020-10-27 21:34 ` Shuah Khan
2020-10-20 23:51 ` [PATCH v3 06/21] selftests/resctrl: Check for resctrl mount point only if resctrl FS is supported Fenghua Yu
2020-10-20 23:51 ` [PATCH v3 07/21] selftests/resctrl: Use resctrl/info for feature detection Fenghua Yu
2020-10-20 23:51 ` [PATCH v3 08/21] selftests/resctrl: Ensure sibling CPU is not same as original CPU Fenghua Yu
2020-10-20 23:51 ` [PATCH v3 09/21] selftests/resctrl: Fix missing options "-n" and "-p" Fenghua Yu
2020-10-20 23:51 ` [PATCH v3 10/21] selftests/resctrl: Fix MBA/MBM results reporting format Fenghua Yu
2020-10-20 23:51 ` [PATCH v3 11/21] selftests/resctrl: Abort running tests if not root user Fenghua Yu
2020-10-20 23:51 ` [PATCH v3 12/21] selftests/resctrl: Enable gcc checks to detect buffer overflows Fenghua Yu
2020-10-20 23:51 ` [PATCH v3 13/21] selftests/resctrl: Don't hard code value of "no_of_bits" variable Fenghua Yu
2020-10-20 23:51 ` [PATCH v3 14/21] selftests/resctrl: Modularize resctrl test suite main() function Fenghua Yu
2020-10-20 23:51 ` [PATCH v3 15/21] selftests/resctrl: Skip the test if requested resctrl feature is not supported Fenghua Yu
2020-10-20 23:51 ` [PATCH v3 16/21] selftests/resctrl: Umount resctrl FS only if mounted Fenghua Yu
2020-10-20 23:51 ` [PATCH v3 17/21] selftests/resctrl: Unmount resctrl FS after running all tests Fenghua Yu
2020-10-20 23:51 ` [PATCH v3 18/21] selftests/resctrl: Fix incorrect parsing of iMC counters Fenghua Yu
2020-10-20 23:51 ` [PATCH v3 19/21] selftests/resctrl: Fix checking for < 0 for unsigned values Fenghua Yu
2020-10-20 23:51 ` [PATCH v3 20/21] selftests/resctrl: Fix unnecessary usage of global variables Fenghua Yu
2020-10-20 23:51 ` [PATCH v3 21/21] selftests/resctrl: Don't use global variable for capacity bitmask (CBM) Fenghua Yu
2020-10-28 0:46 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4fe6c5a-e5c4-0653-9e35-ab03f5494744@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=fenghua.yu@intel.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=ravi.v.shankar@intel.com \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).