From: Dan Murphy <dmurphy@ti.com>
To: Akinobu Mita <akinobu.mita@gmail.com>,
<linux-leds@vger.kernel.org>, <devicetree@vger.kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Bjorn Andersson <bjorn@kryo.se>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Jean-Jacques Hiblot <jjhiblot@ti.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH 2/2] leds: meter: add leds-meter binding
Date: Wed, 23 Oct 2019 07:34:39 -0500 [thread overview]
Message-ID: <0f58e263-7e56-b4f7-51c1-a37e107a1afe@ti.com> (raw)
In-Reply-To: <1571756812-19005-3-git-send-email-akinobu.mita@gmail.com>
Akinobu
On 10/22/19 10:06 AM, Akinobu Mita wrote:
> Add DT binding for leds-meter.
$subject should be
dt-bindings: leds: Add leds-meter binding
And this patch should be first in the series
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Bjorn Andersson <bjorn@kryo.se>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: Jean-Jacques Hiblot <jjhiblot@ti.com>
> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Dan Murphy <dmurphy@ti.com>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> ---
> .../devicetree/bindings/leds/leds-meter.yaml | 42 ++++++++++++++++++++++
> 1 file changed, 42 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/leds-meter.yaml
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-meter.yaml b/Documentation/devicetree/bindings/leds/leds-meter.yaml
> new file mode 100644
> index 0000000..d5dfa261
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-meter.yaml
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/leds-meter.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Generic LED level meter
> +
> +maintainers:
> + - Akinobu Mita <akinobu.mita@gmail.com>
> +
> +description:
> + Generic LED level meter consists of multiple LED devices by different drivers.
> +
> +properties:
> + compatible:
> + const: meter-leds
> +
> + leds:
This seems a bit generic for the property name
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + minItems: 1
> + description: List of phandles to LED node that are members of a level meter.
> +
> + brightness-weights:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + minItems: 1
> + description: Each integer represents a contribution ratio within a level
> + meter.
This description is a bit vague I would not be sure what I would set
this to.
Dan
> +
> +required:
> + - compatible
> + - leds
> +
> +examples:
> + - |
> + leds {
> + compatible = "meter-leds";
> + leds = <&led0>, <&led1>, <&led2>, <&led3>;
> + brightness-weights = <3 1 1 1>;
> + };
> +
> +...
next prev parent reply other threads:[~2019-10-23 12:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 15:06 [PATCH 0/2] leds: add generic LED level meter driver Akinobu Mita
2019-10-22 15:06 ` [PATCH 1/2] leds: add " Akinobu Mita
2019-10-22 15:06 ` [PATCH 2/2] leds: meter: add leds-meter binding Akinobu Mita
2019-10-23 12:34 ` Dan Murphy [this message]
2019-10-23 14:45 ` Akinobu Mita
2019-10-23 14:56 ` Rob Herring
2019-12-04 12:38 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f58e263-7e56-b4f7-51c1-a37e107a1afe@ti.com \
--to=dmurphy@ti.com \
--cc=akinobu.mita@gmail.com \
--cc=bjorn@kryo.se \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jjhiblot@ti.com \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).