From: Tony Lindgren <tony@atomide.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Dan Murphy <dmurphy@ti.com>,
jacek.anaszewski@gmail.com, sre@kernel.org, nekit1000@gmail.com,
mpartap@gmx.net, merlijn@wizzup.org, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/5] leds: lm3532: Fix brightness control for i2c mode
Date: Mon, 26 Aug 2019 15:44:37 -0700 [thread overview]
Message-ID: <20190826224437.GZ52127@atomide.com> (raw)
In-Reply-To: <20190826221413.GA19124@amd>
* Pavel Machek <pavel@ucw.cz> [190826 22:14]:
> On Mon 2019-08-26 14:58:22, Tony Lindgren wrote:
> > Hi,
> >
> > * Dan Murphy <dmurphy@ti.com> [190820 19:53]:
> > > Fix the brightness control for I2C mode. Instead of
> > > changing the full scale current register update the ALS target
> > > register for the appropriate banks.
> > >
> > > In addition clean up some code errors and random misspellings found
> > > during coding.
> > >
> > > Tested on Droid4 as well as LM3532 EVM connected to a BeagleBoneBlack
> > >
> > > Fixes: e37a7f8d77e1 ("leds: lm3532: Introduce the lm3532 LED driver")
> > > Reported-by: Pavel Machek <pavel@ucw.cz>
> > > Signed-off-by: Dan Murphy <dmurphy@ti.com>
> > > ---
> > >
> > > v3 - Removed register define updates - https://lore.kernel.org/patchwork/patch/1114542/
> >
> > Looks like starting with this patch in Linux next the LCD on droid4
> > is so dim it's unreadable even with brightness set to 255. Setting
> > brightness to 0 does blank it completely though.
> >
> > Did something maybe break with the various patch revisions or are
> > we now missing some dts patch?
>
> Maybe missing dts patch. We should provide maximum current the LED can
> handle...
Or i2c control is somehow broken and only als control now works?
Regards,
Tony
next prev parent reply other threads:[~2019-08-26 22:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 19:53 [PATCH v3 1/5] leds: lm3532: Fix brightness control for i2c mode Dan Murphy
2019-08-20 19:53 ` [PATCH v3 2/5] leds: lm3532: Change the define for the fs current register Dan Murphy
2019-08-25 9:32 ` Pavel Machek
2019-08-27 21:33 ` Jacek Anaszewski
2019-08-27 21:37 ` Jacek Anaszewski
2019-08-20 19:53 ` [PATCH v3 3/5] leds: lm3532: Fixes for the driver for stability Dan Murphy
2019-08-20 19:53 ` [PATCH v3 4/5] dt: lm3532: Add property for full scale current Dan Murphy
2019-08-20 19:53 ` [PATCH v3 5/5] leds: lm3532: Add full scale current configuration Dan Murphy
2019-08-25 10:50 ` [PATCH v3 1/5] leds: lm3532: Fix brightness control for i2c mode Jacek Anaszewski
2019-08-26 21:58 ` Tony Lindgren
2019-08-26 22:14 ` Pavel Machek
2019-08-26 22:44 ` Tony Lindgren [this message]
2019-08-27 12:03 ` Dan Murphy
2019-08-27 12:18 ` Pavel Machek
2019-08-27 12:44 ` Dan Murphy
[not found] ` <9939e253-0c9e-5ef7-e160-c1e5fe99c453@ti.com>
2019-08-27 16:04 ` Tony Lindgren
2019-08-27 16:19 ` Dan Murphy
2019-08-27 16:45 ` Tony Lindgren
2019-08-27 21:14 ` Jacek Anaszewski
2019-08-28 15:28 ` Dan Murphy
2019-08-28 20:37 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190826224437.GZ52127@atomide.com \
--to=tony@atomide.com \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=mpartap@gmx.net \
--cc=nekit1000@gmail.com \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).