From: Pavel Machek <pavel@ucw.cz>
To: Nicolas Belin <nbelin@baylibre.com>
Cc: linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
jacek.anaszewski@gmail.com, dmurphy@ti.com,
devicetree@vger.kernel.org, baylibre-upstreaming@groups.io
Subject: Re: [PATCH v3 3/3] drivers: leds: add support for apa102c leds
Date: Tue, 24 Mar 2020 10:42:22 +0100 [thread overview]
Message-ID: <20200324094222.GA15096@amd> (raw)
In-Reply-To: <1583502010-16210-4-git-send-email-nbelin@baylibre.com>
[-- Attachment #1: Type: text/plain, Size: 930 bytes --]
On Fri 2020-03-06 14:40:10, Nicolas Belin wrote:
> Initilial commit in order to support the apa102c RGB leds. The
Initial
> RGB and global brightness management is done by creating 4 leds
> from the Led Framework per apa102c led.
>
> +
> + /* setting a color_id value for each of the 4 components of the
> + * apa102c RGB led. The first component is the global brightness
> + * of the led and thus has no color. The order of the colors
> + * after the global brightness is then blue, green and red
> + * in that order. It corresponds to the order in which the
> + * values are sent using spi
> + */
> + rgb_led->component[0].color_id = -1; //no color
Please follow codingstyle on comment style and avoid // comments.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2020-03-24 9:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 13:40 [PATCH v3 0/3] leds: add support for apa102c leds Nicolas Belin
2020-03-06 13:40 ` [PATCH v3 1/3] dt-bindings: Document shiji vendor-prefix Nicolas Belin
2020-03-09 21:05 ` Rob Herring
2020-03-06 13:40 ` [PATCH v3 2/3] dt-bindings: leds: Shiji Lighting APA102C LED Nicolas Belin
2020-03-06 20:19 ` Jacek Anaszewski
2020-03-13 13:06 ` Rob Herring
2020-03-06 13:40 ` [PATCH v3 3/3] drivers: leds: add support for apa102c leds Nicolas Belin
2020-03-06 20:20 ` Jacek Anaszewski
2020-03-09 9:59 ` Nicolas Belin
2020-03-24 9:42 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324094222.GA15096@amd \
--to=pavel@ucw.cz \
--cc=baylibre-upstreaming@groups.io \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=nbelin@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).