From: Pavel Machek <pavel@ucw.cz>
To: Marek Behun <marek.behun@nic.cz>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
linux-leds@vger.kernel.org, jacek.anaszewski@gmail.com,
"Dan Murphy" <dmurphy@ti.com>,
"Ondřej Jirman" <megous@megous.com>,
netdev@vger.kernel.org, "Russell King" <linux@armlinux.org.uk>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Gregory Clement" <gregory.clement@bootlin.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC leds + net-next v2 1/1] net: phy: marvell: add support for PHY LEDs via LED class
Date: Fri, 24 Jul 2020 12:24:03 +0200 [thread overview]
Message-ID: <20200724102403.wyuteeql3jn5xouw@duo.ucw.cz> (raw)
In-Reply-To: <20200724005349.2e90a247@nic.cz>
[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]
Hi!
> > I expect some of this should be moved into the phylib core. We don't
> > want each PHY inventing its own way to do this. The core should
> > provide a framework and the PHY driver fills in the gaps.
> >
> > Take a look at for example mscc_main.c and its LED information. It has
> > pretty similar hardware to the Marvell. And microchip.c also has LED
> > handling, etc.
>
> OK, this makes sense. I will have to think about this a little.
>
> My main issue though is whether one "hw-control" trigger should be
> registered via LED API and the specific mode should be chosen via
> another sysfs file as in this RFC, or whether each HW control mode
> should have its own trigger. The second solution would either result in
> a lot of registered triggers or complicate LED API, though...
If you register say 5 triggers.... that's okay. If you do like 1024
additional triggers (it happened before!)... well please don't.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2020-07-24 10:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 18:13 [PATCH RFC leds + net-next v2 0/1] Add support for LEDs on Marvell PHYs Marek Behún
2020-07-23 18:13 ` [PATCH RFC leds + net-next v2 1/1] net: phy: marvell: add support for PHY LEDs via LED class Marek Behún
2020-07-23 21:35 ` Andrew Lunn
2020-07-23 21:44 ` Pavel Machek
2020-07-23 21:46 ` Marek Behun
2020-07-23 22:53 ` Marek Behun
2020-07-24 10:24 ` Pavel Machek [this message]
2020-07-24 13:11 ` Andrew Lunn
2020-07-25 9:41 ` Pavel Machek
2020-07-24 10:29 ` [PATCH RFC leds + net-next v2 0/1] Add support for LEDs on Marvell PHYs Pavel Machek
2020-07-24 13:12 ` Marek Behún
2020-07-24 13:18 ` Marek Behún
2020-07-24 22:38 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724102403.wyuteeql3jn5xouw@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=andrew@lunn.ch \
--cc=dmurphy@ti.com \
--cc=gregory.clement@bootlin.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marek.behun@nic.cz \
--cc=megous@megous.com \
--cc=netdev@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).