linux-leds.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: linux-leds@vger.kernel.org, dmurphy@ti.com,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: ledtrig-cpu: Limit to 4 CPUs
Date: Sun, 20 Sep 2020 20:34:01 +0200	[thread overview]
Message-ID: <20200920183401.GA21494@duo.ucw.cz> (raw)
In-Reply-To: <27e19ac9-4bc0-2945-3985-6cd6bb5407df@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]

Hi!

> >    *
> >    * It can be bound to any LED just like other triggers using either a
> >    * board file or via sysfs interface.
> >    *
> >    * An API named ledtrig_cpu is exported for any user, who want to add CPU
> > - * activity indication in their code
> > + * activity indication in their code.
> >    *
> >    * Copyright 2011 Linus Walleij <linus.walleij@linaro.org>
> >    * Copyright 2011 - 2012 Bryan Wu <bryan.wu@canonical.com>
> > @@ -145,6 +149,9 @@ static int __init ledtrig_cpu_init(void)
> >   	for_each_possible_cpu(cpu) {
> >   		struct led_trigger_cpu *trig = &per_cpu(cpu_trig, cpu);
> > +		if (cpu > 4)
> 
> NACK. The workaround for this trigger was implemented for a reason -
> to make it working on platforms with arbitrary number of logical cpus.
> I've got 8, so I am discriminated now. Not saying, that it precludes
> trigger registration with no single line of warning.

Can I get details of your setup?

What CPU type that is, and how are you mapping CPU activity to LEDs?

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

  parent reply	other threads:[~2020-09-20 18:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-19  9:38 ledtrig-cpu: Limit to 4 CPUs Pavel Machek
2020-09-20 14:15 ` Jacek Anaszewski
2020-09-20 15:39   ` Marek Behun
2020-09-20 16:55     ` Jacek Anaszewski
2020-09-20 17:33       ` Marek Behun
2020-09-20 17:49         ` Jacek Anaszewski
2020-09-20 18:34   ` Pavel Machek [this message]
2020-09-21 22:14     ` Jacek Anaszewski
2020-09-21 22:42       ` Pavel Machek
2020-09-22 20:41         ` Jacek Anaszewski
2020-09-25  8:51           ` Jacek Anaszewski
2020-09-25  9:40             ` Pavel Machek
2020-09-26 13:59               ` Jacek Anaszewski
2020-10-08 10:10                 ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200920183401.GA21494@duo.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=dmurphy@ti.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).