From: Pavel Machek <pavel@ucw.cz>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "Álvaro Fernández Rojas" <noltari@gmail.com>,
"Dan Murphy" <dmurphy@ti.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] leds: bcm6328: improve write and read functions
Date: Wed, 24 Feb 2021 18:36:50 +0100 [thread overview]
Message-ID: <20210224173649.GA10809@amd> (raw)
In-Reply-To: <a2da8ee6-a941-de04-3d45-56fb6cae596a@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1411 bytes --]
Hi!
> >> Yeah, but ideally you should not be copying comments; there should be
> >> one central place which does it and does it right.
> >
> > I’m open to suggestions :).
> > Which central place would be a good place for you?
>
> I did consider creating an include/linux/brcm/brcm_io.h header or
> something like that but I am really not sure what the benefit would
> be.
Less code duplication? It is immediately clear that driver including
this is specific for brcm SoCs and would not try to work somewhere else?
> As far as using _relaxed() this is absolutely correct because the bus
> logic that connects the CPU to its on-chip registers is non re-ordering
> non posted. That is true on the MIPS BE/LE and ARM when configured in LE
> or BE.
If that's right on particular SoC, then _relaxed and normal versions
should be same; drivers still need to use normal versions, because
they may be running on different SoC...?
> We need the swapping for ARM because when running in ARM BE32, the data
> is going to be in the host CPU endian, but the register bus is hard
> wired to little endian.
Yeah I see you need to do some byteswapping. But I'm pretty sure not
all MIPS BE boxes do the magic swapping, right? And drivers/leds is
not a place where you encode knowledge about SoC byte swapping.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2021-02-24 17:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 8:17 [PATCH 0/2] leds: bcm63x8: improve read and write functions Álvaro Fernández Rojas
2021-02-23 8:17 ` [PATCH 1/2] leds: bcm6328: improve write and read functions Álvaro Fernández Rojas
2021-02-23 8:34 ` Pavel Machek
2021-02-23 8:42 ` Álvaro Fernández Rojas
2021-02-23 8:58 ` Pavel Machek
2021-02-23 9:05 ` Álvaro Fernández Rojas
2021-02-23 17:00 ` Florian Fainelli
2021-02-24 17:36 ` Pavel Machek [this message]
2021-02-24 17:45 ` Florian Fainelli
2021-02-24 21:45 ` Pavel Machek
2021-02-23 8:17 ` [PATCH 2/2] leds: bcm6358: " Álvaro Fernández Rojas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210224173649.GA10809@amd \
--to=pavel@ucw.cz \
--cc=dmurphy@ti.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=noltari@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).