From: Pavel Machek <pavel@ucw.cz>
To: Hermes Zhang <chenhui.zhang@axis.com>
Cc: Dan Murphy <dmurphy@ti.com>,
kernel@axis.com, Hermes Zhang <chenhuiz@axis.com>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v3] leds: leds-multi-gpio: Add multiple GPIOs LED driver
Date: Wed, 4 Aug 2021 17:52:21 +0200 [thread overview]
Message-ID: <20210804155221.GB25072@amd> (raw)
In-Reply-To: <20210329055847.13293-1-chenhui.zhang@axis.com>
[-- Attachment #1: Type: text/plain, Size: 628 bytes --]
Hi!
> From: Hermes Zhang <chenhuiz@axis.com>
>
> Introduce a new multiple GPIOs LED driver. This LED will made of
> multiple GPIOs (up to 8) and will map different brightness to different
> GPIOs states which defined in dts file.
>
> Signed-off-by: Hermes Zhang <chenhuiz@axis.com>
Thank you, it looks simple and mostly ok.
Acked-by: Pavel Machek <pavel@ucw.cz>
But it really needs to go in with devicetree documentation changes,
and they need to be acked by devicetree maintainers. If you have that,
please send it in series.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2021-08-04 15:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 5:58 [PATCH v3] leds: leds-multi-gpio: Add multiple GPIOs LED driver Hermes Zhang
2021-08-04 15:52 ` Pavel Machek [this message]
2021-08-09 6:29 ` Hermes Zhang
2021-08-18 7:01 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210804155221.GB25072@amd \
--to=pavel@ucw.cz \
--cc=chenhui.zhang@axis.com \
--cc=chenhuiz@axis.com \
--cc=dmurphy@ti.com \
--cc=kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).