From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Dan Murphy <dmurphy@ti.com>, pavel@ucw.cz
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] documention: leds: Add multicolor class documentation
Date: Tue, 16 Jul 2019 22:37:40 +0200 [thread overview]
Message-ID: <6e5daa02-f507-e329-cc56-465954d0996b@gmail.com> (raw)
In-Reply-To: <9112080d-a53e-8c2b-ebfa-6e4ff9eed3c3@ti.com>
Dan,
On 7/16/19 9:27 PM, Dan Murphy wrote:
> Jacek
>
> On 7/16/19 2:18 PM, Jacek Anaszewski wrote:
>> Hi Dan,
>>
>> Thanks for the update. I have some nits below, please take a look.
>>
>> On 7/1/19 10:46 PM, Dan Murphy wrote:
[...]
>>> +The user can control the brightness of that RGB group by writing the
>>> parent
>>> +'brightness' control. Assuming a parent max_brightness of 255 the
>>> user may want
>>> +to dim the LED color group to half. The user would write a value of
>>> 128 to the
>>> +parent brightness file then the values written to each LED will be
>>> adjusted
>>> +base on this value
>> We probably need to state here that any amendment to color intensity
>> values resets brightness to its max value.
>
> Well that is not true. Intensity and brightness are two different spaces.
OK, I had to go through the sequence of steps I had on mind.
I had to work it out that colors set under colors directory don't
reflect the iout colors, but are only used for calculating them,
basing on the brightness and max_intensity values.
Effectively, after changing the colors/<color>/intensity the brightness
value will be still valid, since iout color will be recalculated basing
on the currently set brightness and the new color intensity.
> Brightness is for cluster control and intensity is for monochrome LED
> control.
>
> There only relationship is when setting cluster brightness.
--
Best regards,
Jacek Anaszewski
prev parent reply other threads:[~2019-07-16 20:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 20:46 [PATCH v5 0/2] Multicolor Documentation update Dan Murphy
2019-07-01 20:46 ` [PATCH v5 1/2] leds: multicolor: Add sysfs interface definition Dan Murphy
2019-07-01 20:46 ` [PATCH v5 2/2] documention: leds: Add multicolor class documentation Dan Murphy
2019-07-16 19:18 ` Jacek Anaszewski
2019-07-16 19:27 ` Dan Murphy
2019-07-16 20:37 ` Jacek Anaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e5daa02-f507-e329-cc56-465954d0996b@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).