From: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
To: "pavel@ucw.cz" <pavel@ucw.cz>
Cc: "linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"dmurphy@ti.com" <dmurphy@ti.com>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"mazziesaccount@gmail.com" <mazziesaccount@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"jacek.anaszewski@gmail.com" <jacek.anaszewski@gmail.com>,
"a.zummo@towertech.it" <a.zummo@towertech.it>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"lee.jones@linaro.org" <lee.jones@linaro.org>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"broonie@kernel.org" <broonie@kernel.org>
Subject: Re: [PATCH v7 12/12] led: bd71828: Support LED outputs on ROHM BD71828 PMIC
Date: Fri, 27 Dec 2019 09:43:24 +0000 [thread overview]
Message-ID: <75e9d581aef0127b4e24eb06b57ef397842cf7c9.camel@fi.rohmeurope.com> (raw)
In-Reply-To: <20191221194802.GK32732@amd>
On Sat, 2019-12-21 at 20:48 +0100, Pavel Machek wrote:
> Hi!
>
> > ROHM BD71828 power management IC has two LED outputs for charge
> > status
> > and button pressing indications. The LED outputs can also be forced
> > by SW so add driver allowing to use these LEDs for other
> > indications
> > as well.
> >
> > Leds are controlled by SW using 'Force ON' bits. Please note the
> > constrains mentioned in data-sheet:
> > 1. If one LED is forced ON - then also the other LED is forced.
> > => You can't use SW control to force ON one LED and
> > allow HW
> > to control the other.
> > 2. You can't force both LEDs OFF. If the FORCE bit for both
> > LED's is
> > zero, then LEDs are controlled by HW and indicate
> > button/charger
> > states as explained in data-sheet.
>
> That's really quite sad, is it?
>
> All the effort and all we got is ... one working LED. Because
> hardware
> does not allow you to control both LEDs...
Yes and no. I do fully agree that it would be much nicer if the LEDs
could be set to be fully controlled by SW. OTOH, knowing the LEDs are
usually OFF, using them to indicate something else is still doable. I
think you know typical LED use-cases better than I do - but I guess
that some blink pattern in order to indicate errors is well doable with
these LEDs.
> ...and we don't even have support selecting if the LED should be sw
> or
> hw controlled in the mainline, yet...
Which sounds like we have such support somewhere - and hopefully in
mainline one day ;)
Anyways, Thanks for taking a look at this! :)
Br,
Matti Vaittinen
prev parent reply other threads:[~2019-12-27 9:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 9:44 [PATCH v7 00/12] Support ROHM BD71828 PMIC Matti Vaittinen
2019-12-19 9:44 ` [PATCH v7 01/12] dt-bindings: leds: ROHM BD71282 PMIC LED driver Matti Vaittinen
2019-12-21 19:26 ` Pavel Machek
2019-12-19 9:46 ` [PATCH v7 02/12] dt-bindings: mfd: Document ROHM BD71828 bindings Matti Vaittinen
2019-12-19 9:58 ` Vaittinen, Matti
2019-12-19 14:36 ` Lee Jones
2019-12-20 6:33 ` Vaittinen, Matti
2019-12-20 10:55 ` Lee Jones
2019-12-19 9:46 ` [PATCH v7 03/12] mfd: rohm PMICs - use platform_device_id to match MFD sub-devices Matti Vaittinen
2019-12-19 9:49 ` [PATCH v7 04/12] mfd: bd718x7: Add compatible for BD71850 Matti Vaittinen
2019-12-19 9:50 ` [PATCH v7 05/12] mfd: bd71828: Support ROHM BD71828 PMIC - core Matti Vaittinen
2019-12-19 9:51 ` [PATCH v7 06/12] mfd: input: bd71828: Add power-key support Matti Vaittinen
2019-12-19 9:52 ` [PATCH v7 07/12] clk: bd718x7: Support ROHM BD71828 clk block Matti Vaittinen
2019-12-24 6:54 ` Stephen Boyd
2019-12-19 9:52 ` [PATCH v7 08/12] regulator: bd718x7: Split driver to common and bd718x7 specific parts Matti Vaittinen
2019-12-19 9:53 ` [PATCH v7 09/12] rtc: bd70528: add BD71828 support Matti Vaittinen
2019-12-19 9:53 ` [PATCH v7 10/12] gpio: bd71828: Initial support for ROHM BD71828 PMIC GPIOs Matti Vaittinen
2019-12-19 9:54 ` [PATCH v7 11/12] leds: Add common LED binding parsing support to LED class/core Matti Vaittinen
2019-12-21 19:37 ` Pavel Machek
2019-12-23 10:35 ` Vaittinen, Matti
2019-12-27 11:29 ` Vaittinen, Matti
2019-12-27 11:51 ` Vaittinen, Matti
2019-12-30 7:36 ` Vaittinen, Matti
2019-12-19 9:54 ` [PATCH v7 12/12] led: bd71828: Support LED outputs on ROHM BD71828 PMIC Matti Vaittinen
2019-12-21 19:48 ` Pavel Machek
2019-12-27 9:43 ` Vaittinen, Matti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75e9d581aef0127b4e24eb06b57ef397842cf7c9.camel@fi.rohmeurope.com \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mazziesaccount@gmail.com \
--cc=mturquette@baylibre.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).