From: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
To: matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Lee Jones <lee.jones@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org
Subject: [PATCH v10 09/13] mfd: bd70528: Fix hour register mask
Date: Fri, 17 Jan 2020 11:40:28 +0200 [thread overview]
Message-ID: <8609d42822a6ce3755e2166b8c1246b3b04eeb78.1579249511.git.matti.vaittinen@fi.rohmeurope.com> (raw)
In-Reply-To: <cover.1579249511.git.matti.vaittinen@fi.rohmeurope.com>
When RTC is used in 24H mode (and it is by this driver) the maximum
hour value is 24 in BCD. This occupies bits [5:0] - which means
correct mask for HOUR register is 0x3f not 0x1f. Fix the mask
Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528 RTC")
Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
Changes: Splitted this fix into separate patch which can be applied to
5.4 too
include/linux/mfd/rohm-bd70528.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/mfd/rohm-bd70528.h b/include/linux/mfd/rohm-bd70528.h
index 2ad2320d0a96..edae6f7afd8e 100644
--- a/include/linux/mfd/rohm-bd70528.h
+++ b/include/linux/mfd/rohm-bd70528.h
@@ -311,7 +311,7 @@ enum {
#define BD70528_MASK_RTC_MINUTE 0x7f
#define BD70528_MASK_RTC_HOUR_24H 0x80
#define BD70528_MASK_RTC_HOUR_PM 0x20
-#define BD70528_MASK_RTC_HOUR 0x1f
+#define BD70528_MASK_RTC_HOUR 0x3f
#define BD70528_MASK_RTC_DAY 0x3f
#define BD70528_MASK_RTC_WEEK 0x07
#define BD70528_MASK_RTC_MONTH 0x1f
--
2.21.0
--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND
~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =]
next prev parent reply other threads:[~2020-01-17 9:40 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 9:30 [PATCH v10 00/13] Support ROHM BD71828 PMIC Matti Vaittinen
2020-01-17 9:31 ` [PATCH v10 01/13] dt-bindings: leds: ROHM BD71282 PMIC LED driver Matti Vaittinen
2020-01-17 9:32 ` [PATCH v10 02/13] dt-bindings: mfd: Document ROHM BD71828 bindings Matti Vaittinen
2020-01-17 9:34 ` [PATCH v10 03/13] mfd: rohm PMICs - use platform_device_id to match MFD sub-devices Matti Vaittinen
2020-01-17 9:35 ` [PATCH v10 04/13] mfd: bd718x7: Add compatible for BD71850 Matti Vaittinen
2020-01-17 9:36 ` [PATCH v10 05/13] mfd: bd71828: Support ROHM BD71828 PMIC - core Matti Vaittinen
2020-01-17 9:36 ` [PATCH v10 06/13] mfd: input: bd71828: Add power-key support Matti Vaittinen
2020-01-17 9:37 ` [PATCH v10 07/13] clk: bd718x7: Support ROHM BD71828 clk block Matti Vaittinen
2020-01-17 9:38 ` [PATCH v10 08/13] regulator: bd718x7: Split driver to common and bd718x7 specific parts Matti Vaittinen
2020-01-17 10:28 ` Lee Jones
2020-01-17 10:43 ` Vaittinen, Matti
2020-01-17 13:40 ` Lee Jones
2020-01-20 7:06 ` Vaittinen, Matti
2020-01-17 9:40 ` Matti Vaittinen [this message]
2020-01-17 10:21 ` [PATCH v10 09/13] mfd: bd70528: Fix hour register mask Lee Jones
2020-01-17 9:42 ` [PATCH v10 10/13] rtc: bd70528: add BD71828 support Matti Vaittinen
2020-01-17 9:42 ` [PATCH v10 11/13] gpio: bd71828: Initial support for ROHM BD71828 PMIC GPIOs Matti Vaittinen
2020-01-17 10:21 ` Lee Jones
2020-01-20 6:48 ` Vaittinen, Matti
2020-01-20 8:02 ` Lee Jones
2020-01-23 15:18 ` Linus Walleij
2020-01-17 9:43 ` [PATCH v10 12/13] leds: Add common LED binding parsing support to LED class/core Matti Vaittinen
2020-01-20 8:56 ` Vaittinen, Matti
2020-01-17 9:44 ` [PATCH v10 13/13] led: bd71828: Support LED outputs on ROHM BD71828 PMIC Matti Vaittinen
2020-01-17 10:30 ` [PATCH v10 00/13] Support " Lee Jones
2020-01-17 10:48 ` Vaittinen, Matti
2020-01-17 13:44 ` Lee Jones
2020-02-26 13:42 ` Pavel Machek
2020-02-26 14:25 ` Vaittinen, Matti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8609d42822a6ce3755e2166b8c1246b3b04eeb78.1579249511.git.matti.vaittinen@fi.rohmeurope.com \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mazziesaccount@gmail.com \
--cc=mturquette@baylibre.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).