From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Amireddy Mallikarjuna reddy <mallikarjunax.reddy@linux.intel.com>
Cc: linux-leds <linux-leds@vger.kernel.org>,
Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
cheol.yong.kim@intel.com, qi-ming.wu@intel.com,
malliamireddy009@gmail.com, yixin.zhu@intel.com
Subject: Re: [PATCH v3 2/2] leds: lgm: Add LED controller driver for LGM SoC
Date: Tue, 2 Mar 2021 11:36:27 +0100 [thread overview]
Message-ID: <CAMuHMdW=M6wougrQMjBdTfFQzPbEQOM-Svq=DTQi8Rvzabxc_g@mail.gmail.com> (raw)
In-Reply-To: <dfd39387b1f72eb22a29bad516398a47b20c47bc.1607591119.git.mallikarjunax.reddy@linux.intel.com>
Hi Amireddy,
On Thu, Dec 10, 2020 at 10:20 AM Amireddy Mallikarjuna reddy
<mallikarjunax.reddy@linux.intel.com> wrote:
> Parallel to serial conversion, which is also called SSO controller,
> can drive external shift register for LED outputs, reset or
> general purpose outputs.
>
> This driver enables LED support for Serial Shift Output Controller (SSO).
>
> Signed-off-by: Amireddy Mallikarjuna reddy <mallikarjunax.reddy@linux.intel.com>
Thanks for your patch, which is now commit c3987cd2bca34ddf ("leds: lgm:
Add LED controller driver for LGM SoC") in v5.12-rc1.
> --- /dev/null
> +++ b/drivers/leds/blink/Kconfig
> @@ -0,0 +1,20 @@
> +menuconfig LEDS_BLINK
> + bool "LED Blink support"
> + depends on LEDS_CLASS
> + help
> + This option enables blink support for the leds class.
> + If unsure, say Y.
What is the purpose of the LEDS_BLINK config symbol?
Blink support for the leds class is always available, regardless of the
value of this symbol, and controlled for individual drivers by filling
in the led_classdev.blink_set() callback.
> +
> +if LEDS_BLINK
> +
> +config LEDS_BLINK_LGM
> + tristate "LED support for Intel LGM SoC series"
> + depends on LEDS_CLASS
> + depends on MFD_SYSCON
> + depends on OF
> + help
> + Parallel to serial conversion, which is also called SSO controller,
> + can drive external shift register for LED outputs.
> + This enables LED support for Serial Shift Output controller(SSO).
What's so special about this driver that it needs a new "blink" subdir?
Isn't it an ordinary LED driver?
Looking at the code filling in the .blink_set() callback, the hardware
blink feature seems to be even optional?
> +
> +endif # LEDS_BLINK
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2021-03-03 2:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 9:12 [PATCH v3 1/2] dt-bindings: leds: Add bindings for Intel LGM SoC Amireddy Mallikarjuna reddy
2020-12-10 9:12 ` [PATCH v3 2/2] leds: lgm: Add LED controller driver for " Amireddy Mallikarjuna reddy
2021-03-02 10:36 ` Geert Uytterhoeven [this message]
2021-03-02 15:55 ` Pavel Machek
2020-12-11 3:45 ` [PATCH v3 1/2] dt-bindings: leds: Add bindings for Intel " Rob Herring
2021-02-19 10:40 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdW=M6wougrQMjBdTfFQzPbEQOM-Svq=DTQi8Rvzabxc_g@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=cheol.yong.kim@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=malliamireddy009@gmail.com \
--cc=mallikarjunax.reddy@linux.intel.com \
--cc=pavel@ucw.cz \
--cc=qi-ming.wu@intel.com \
--cc=robh+dt@kernel.org \
--cc=yixin.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).