From: "Bollinger, Seth" <Seth.Bollinger@digi.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Bollinger, Seth" <Seth.Bollinger@digi.com>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
Dan Murphy <dmurphy@ti.com>, Seth Bollinger <seth.boll@gmail.com>
Subject: Re: Strange timer LED behavior
Date: Tue, 20 Oct 2020 12:31:14 +0000 [thread overview]
Message-ID: <DF67F732-7B99-4C32-A7E9-4595E2B1E82A@digi.com> (raw)
In-Reply-To: <20201020122149.GA19856@duo.ucw.cz>
>>>> Yep. It allows hardware to provide different values if it can only
>>>> blink at fixed rate.
>>>
>>> Ok, I understand how hardware might make a different choice, but in this scenario we’re using software to blink, so everything is handled by the kernel. Also, if the interface is hardware enabled, isn’t the path at line 177 used (which returns before the default is set)?
>>
>> Why should software blink need to select a default rate since it should be able to handle all requests (even 0, 0)?
>>
>
> How can software blink at "0, 0"?
This would mean, don’t blink. :).
Since we’re using sysfs, we need to update those values in 2 FS writes. It appears that the sysfs is reordering the writes, so we can’t control what value is written when, so it glitches for us. We change off first, then on, but the order of the calls in the kernel is on first (with off already 0), the kernel changes values to default, then the off is written, leaving on with a value of 500 (we set it to 0) and off with the value we wanted.
Is there a way to avoid this? Even if we write the on value twice, it will flash for 500ms at least once…
I tried setting the trigger to none, but of course this disabled the display settings and setting the trigger to timer ends up flashing at the default rate, which is also what we don’t want.
>
> 0, 0 simply means "use defaults", for hardware and software. Its old
> API, so you'll have to live with it.
Ok.
>
> Pavel
> --
> https://linkprotect.cudasvc.com/url?a=http%3a%2f%2fwww.livejournal.com%2f~pavelmachek&c=E,1,LHg8yP6R6j23ZCidNyis2lOGhVeQZPy-0zT0-KT2rQ7lS3g3GWhmUMpYB72mDnw_4DaULTMkW0db0ibj1BSW1MR466DO5DZqcHbZwzQ6&typo=1
>
>
next prev parent reply other threads:[~2020-10-20 12:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 13:08 Strange timer LED behavior Bollinger, Seth
2020-10-19 14:06 ` Pavel Machek
2020-10-19 14:16 ` Bollinger, Seth
2020-10-20 12:04 ` Bollinger, Seth
2020-10-20 12:21 ` Pavel Machek
2020-10-20 12:31 ` Bollinger, Seth [this message]
2020-10-20 18:08 ` Pavel Machek
2020-10-20 18:28 ` Bollinger, Seth
2020-10-20 18:33 ` Pavel Machek
2020-10-20 18:35 ` Bollinger, Seth
2020-10-20 18:40 ` Pavel Machek
2020-10-20 18:51 ` Bollinger, Seth
2020-10-22 10:06 ` Pavel Machek
2020-10-22 11:34 ` Bollinger, Seth
2020-10-24 7:45 ` Pavel Machek
2020-10-21 20:23 ` Jacek Anaszewski
2020-10-22 11:35 ` Bollinger, Seth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DF67F732-7B99-4C32-A7E9-4595E2B1E82A@digi.com \
--to=seth.bollinger@digi.com \
--cc=dmurphy@ti.com \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=seth.boll@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).