From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Dan Murphy <dmurphy@ti.com>, pavel@ucw.cz
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] leds: flash: Remove extern from the header file
Date: Tue, 1 Oct 2019 22:57:26 +0200 [thread overview]
Message-ID: <a6601fe9-0723-baec-d610-aafe7731c80d@gmail.com> (raw)
In-Reply-To: <20191001180439.8312-3-dmurphy@ti.com>
Dan,
Thank you for the patch.
Could we have similar patch for leds.h when we are at it,
if you wouldn't mind?
--
Best regards,
Jacek Anaszewski
On 10/1/19 8:04 PM, Dan Murphy wrote:
> extern is implied and is not needed in the header file.
> Remove the extern keyword and re-align the code.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
> include/linux/led-class-flash.h | 22 ++++++++++------------
> 1 file changed, 10 insertions(+), 12 deletions(-)
>
> diff --git a/include/linux/led-class-flash.h b/include/linux/led-class-flash.h
> index 7ff287a9e2a2..1bd83159fa4c 100644
> --- a/include/linux/led-class-flash.h
> +++ b/include/linux/led-class-flash.h
> @@ -94,12 +94,12 @@ static inline struct led_classdev_flash *lcdev_to_flcdev(
> *
> * Returns: 0 on success or negative error value on failure
> */
> -extern int led_classdev_flash_register_ext(struct device *parent,
> - struct led_classdev_flash *fled_cdev,
> - struct led_init_data *init_data);
> +int led_classdev_flash_register_ext(struct device *parent,
> + struct led_classdev_flash *fled_cdev,
> + struct led_init_data *init_data);
>
> static inline int led_classdev_flash_register(struct device *parent,
> - struct led_classdev_flash *fled_cdev)
> + struct led_classdev_flash *fled_cdev)
> {
> return led_classdev_flash_register_ext(parent, fled_cdev, NULL);
> }
> @@ -111,7 +111,7 @@ static inline int led_classdev_flash_register(struct device *parent,
> *
> * Unregister a previously registered via led_classdev_flash_register object
> */
> -extern void led_classdev_flash_unregister(struct led_classdev_flash *fled_cdev);
> +void led_classdev_flash_unregister(struct led_classdev_flash *fled_cdev);
>
> /**
> * led_set_flash_strobe - setup flash strobe
> @@ -159,8 +159,8 @@ static inline int led_get_flash_strobe(struct led_classdev_flash *fled_cdev,
> *
> * Returns: 0 on success or negative error value on failure
> */
> -extern int led_set_flash_brightness(struct led_classdev_flash *fled_cdev,
> - u32 brightness);
> +int led_set_flash_brightness(struct led_classdev_flash *fled_cdev,
> + u32 brightness);
>
> /**
> * led_update_flash_brightness - update flash LED brightness
> @@ -171,7 +171,7 @@ extern int led_set_flash_brightness(struct led_classdev_flash *fled_cdev,
> *
> * Returns: 0 on success or negative error value on failure
> */
> -extern int led_update_flash_brightness(struct led_classdev_flash *fled_cdev);
> +int led_update_flash_brightness(struct led_classdev_flash *fled_cdev);
>
> /**
> * led_set_flash_timeout - set flash LED timeout
> @@ -182,8 +182,7 @@ extern int led_update_flash_brightness(struct led_classdev_flash *fled_cdev);
> *
> * Returns: 0 on success or negative error value on failure
> */
> -extern int led_set_flash_timeout(struct led_classdev_flash *fled_cdev,
> - u32 timeout);
> +int led_set_flash_timeout(struct led_classdev_flash *fled_cdev, u32 timeout);
>
> /**
> * led_get_flash_fault - get the flash LED fault
> @@ -194,7 +193,6 @@ extern int led_set_flash_timeout(struct led_classdev_flash *fled_cdev,
> *
> * Returns: 0 on success or negative error value on failure
> */
> -extern int led_get_flash_fault(struct led_classdev_flash *fled_cdev,
> - u32 *fault);
> +int led_get_flash_fault(struct led_classdev_flash *fled_cdev, u32 *fault);
>
> #endif /* __LINUX_FLASH_LEDS_H_INCLUDED */
>
next prev parent reply other threads:[~2019-10-01 20:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 18:04 [PATCH 1/5] leds: Kconfig: Be consistent with the usage of "LED" Dan Murphy
2019-10-01 18:04 ` [PATCH 2/5] leds: flash: Convert non extended registration to inline Dan Murphy
2019-10-01 18:04 ` [PATCH 3/5] leds: flash: Remove extern from the header file Dan Murphy
2019-10-01 20:57 ` Jacek Anaszewski [this message]
2019-10-02 11:56 ` Dan Murphy
2019-10-02 19:53 ` Jacek Anaszewski
2019-10-01 18:04 ` [PATCH 4/5] leds: flash: Add devm_* functions to the flash class Dan Murphy
2019-10-01 21:06 ` Jacek Anaszewski
2019-10-01 21:10 ` Jacek Anaszewski
2019-10-02 12:04 ` Dan Murphy
2019-10-02 19:55 ` Jacek Anaszewski
2019-10-01 18:04 ` [PATCH 5/5] leds: lm3601x: Convert class registration to device managed Dan Murphy
2019-10-01 19:39 ` Jacek Anaszewski
2019-10-01 20:11 ` Dan Murphy
2019-10-01 21:16 ` [PATCH 1/5] leds: Kconfig: Be consistent with the usage of "LED" Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6601fe9-0723-baec-d610-aafe7731c80d@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).